Mirrors
/
synapse-old
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix `synapse_event_persisted_position` metric (#12390) 

Fixes a bug introduced in #11417 where we would only included backfilled events
in `synapse_event_persisted_position`
This commit is contained in:
Richard van der Hoff 2022-04-06 14:52:39 +01:00 committed by GitHub
parent ae01a7edd3
commit 6fe757d69e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/12390.bugfix Normal file
View File

@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.49.0 which caused the `synapse_event_persisted_position` metric to have invalid values.

6
synapse/storage/databases/main/events.py
View File

@ -197,9 +197,9 @@ class PersistEventsStore:
) )
persist_event_counter.inc(len(events_and_contexts)) persist_event_counter.inc(len(events_and_contexts))
if stream < 0: if not use_negative_stream_ordering:
# backfilled events have negative stream orderings, so we don't # we don't want to set the event_persisted_position to a negative
# want to set the event_persisted_position to that. # stream_ordering.
synapse.metrics.event_persisted_position.set(stream) synapse.metrics.event_persisted_position.set(stream)
for event, context in events_and_contexts: for event, context in events_and_contexts: