Mirrors
/
synapse-old
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Prometheus metrics being negative (mixed up start/end) (#13584) 

Fix:

 - https://github.com/matrix-org/synapse/pull/13535#discussion_r949582508
 - https://github.com/matrix-org/synapse/pull/13533#discussion_r949577244
This commit is contained in:
Eric Eastwood 2022-08-23 02:47:30 -05:00 committed by GitHub
parent 3dd175b628
commit 9385c41ba4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/13584.misc Normal file
View File

@ -0,0 +1 @@
Add metrics to time how long it takes us to do backfill processing (`synapse_federation_backfill_processing_before_time_seconds`, `synapse_federation_backfill_processing_after_time_seconds`).

7
synapse/handlers/federation.py
View File

@ -86,9 +86,14 @@ backfill_processing_before_timer = Histogram(
"sec", "sec",
[], [],
buckets=( buckets=(
0.1,
0.5,
1.0, 1.0,
2.5,
5.0, 5.0,
7.5,
10.0, 10.0,
15.0,
20.0, 20.0,
30.0, 30.0,
40.0, 40.0,
@ -482,7 +487,7 @@ class FederationHandler:
processing_end_time = self.clock.time_msec() processing_end_time = self.clock.time_msec()
backfill_processing_before_timer.observe( backfill_processing_before_timer.observe(
(processing_start_time - processing_end_time) / 1000 (processing_end_time - processing_start_time) / 1000
) )
success = await try_backfill(likely_domains) success = await try_backfill(likely_domains)

10
synapse/handlers/federation_event.py
View File

@ -104,15 +104,25 @@ backfill_processing_after_timer = Histogram(
"sec", "sec",
[], [],
buckets=( buckets=(
0.1,
0.25,
0.5,
1.0, 1.0,
2.5,
5.0, 5.0,
7.5,
10.0, 10.0,
15.0,
20.0, 20.0,
25.0,
30.0, 30.0,
40.0, 40.0,
50.0,
60.0, 60.0,
80.0, 80.0,
100.0,
120.0, 120.0,
150.0,
180.0, 180.0,
"+Inf", "+Inf",
), ),

6
synapse/rest/client/room.py
View File

@ -116,9 +116,13 @@ messsages_response_timer = Histogram(
2.5, 2.5,
5.0, 5.0,
10.0, 10.0,
20.0,
30.0, 30.0,
60.0, 60.0,
80.0,
100.0,
120.0, 120.0,
150.0,
180.0, 180.0,
"+Inf", "+Inf",
), ),
@ -674,7 +678,7 @@ class RoomMessageListRestServlet(RestServlet):
room_member_count = await make_deferred_yieldable(room_member_count_deferred) room_member_count = await make_deferred_yieldable(room_member_count_deferred)
messsages_response_timer.labels( messsages_response_timer.labels(
room_size=_RoomSize.from_member_count(room_member_count) room_size=_RoomSize.from_member_count(room_member_count)
).observe((processing_start_time - processing_end_time) / 1000) ).observe((processing_end_time - processing_start_time) / 1000)
return 200, msgs return 200, msgs