Mirrors
/
synapse-old
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make SynapseHomeServer _http_listener use self.get_reactor() 

For all the homeserver classes, only the FrontendProxyServer passes
its reactor when doing the http listen. Looking at previous PR's looks
like this was introduced to make it possible to write a test, otherwise
when you try to run a test with the test homeserver it tries to
do a real bind to a port. Passing the reactor that the homeserver
is instantiated with should probably be the right thing to do anyway?

Signed-off-by: Jason Robinson <jasonr@matrix.org>
This commit is contained in:
Jason Robinson 2019-01-18 10:02:08 +02:00
parent 6d25599098
commit a17bac171f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
synapse/app/homeserver.py
View File

@ -130,6 +130,7 @@ class SynapseHomeServer(HomeServer):
self.version_string, self.version_string,
), ),
self.tls_server_context_factory, self.tls_server_context_factory,
reactor=self.get_reactor(),
) )
else: else:
@ -142,7 +143,8 @@ class SynapseHomeServer(HomeServer):
listener_config, listener_config,
root_resource, root_resource,
self.version_string, self.version_string,
) ),
reactor=self.get_reactor(),
) )
logger.info("Synapse now listening on port %d", port) logger.info("Synapse now listening on port %d", port)