Mirrors
/
synapse-old
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix changing password via user admin API. (#6730)

This commit is contained in:
Erik Johnston 2020-01-20 17:23:59 +00:00 committed by GitHub
parent e9e066055f
commit ceecedc68b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/6730.bugfix Normal file
View File

@ -0,0 +1 @@
Fix changing password via user admin API.

4
synapse/rest/admin/users.py
View File

@ -193,8 +193,8 @@ class UserRestServletV2(RestServlet):
raise SynapseError(400, "Invalid password") raise SynapseError(400, "Invalid password")
else: else:
new_password = body["password"] new_password = body["password"]
await self._set_password_handler.set_password( await self.set_password_handler.set_password(
target_user, new_password, requester target_user.to_string(), new_password, requester
) )
if "deactivated" in body: if "deactivated" in body:

13
tests/rest/admin/test_user.py
View File

@ -435,6 +435,19 @@ class UserRestTestCase(unittest.HomeserverTestCase):
self.assertEqual(0, channel.json_body["is_guest"]) self.assertEqual(0, channel.json_body["is_guest"])
self.assertEqual(0, channel.json_body["deactivated"]) self.assertEqual(0, channel.json_body["deactivated"])
# Change password
body = json.dumps({"password": "hahaha"})
request, channel = self.make_request(
"PUT",
self.url,
access_token=self.admin_user_tok,
content=body.encode(encoding="utf_8"),
)
self.render(request)
self.assertEqual(200, int(channel.result["code"]), msg=channel.result["body"])
# Modify user # Modify user
body = json.dumps({"displayname": "foobar", "deactivated": True}) body = json.dumps({"displayname": "foobar", "deactivated": True})