Mirrors
/
synapse-old
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix initialization of `_device_list_id_gen` (#14914) 

On startup, the `_device_list_id_gen` stream id generator is initialized
using the maximum stream id seen in a list of tables. When we started
populating the `device_list_remote_pending` table in #13913, we forgot
to add it to the aforementioned list of tables, so the stream id
generator can hand out old stream ids after a restart. The end result is
that Synapse can fail to handle device list update EDUs after a restart
when a partial state join is in progress.

Add the `device_list_remote_pending` table to the list of tables to
consider when initializing the `_device_list_id_gen` stream id generator.

Signed-off-by: Sean Quah <seanq@matrix.org>
This commit is contained in:
Sean Quah 2023-01-26 10:38:49 +00:00 committed by GitHub
parent f51035bc87
commit cf66d712c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/14914.bugfix Normal file
View File

@ -0,0 +1 @@
Faster joins: Fix a bug introduced in Synapse 1.69 where device list EDUs could fail to be handled after a restart when a faster join sync is in progress.

1
synapse/storage/databases/main/devices.py
View File

@ -99,6 +99,7 @@ class DeviceWorkerStore(RoomMemberWorkerStore, EndToEndKeyWorkerStore):
("user_signature_stream", "stream_id"), ("user_signature_stream", "stream_id"),
("device_lists_outbound_pokes", "stream_id"), ("device_lists_outbound_pokes", "stream_id"),
("device_lists_changes_in_room", "stream_id"), ("device_lists_changes_in_room", "stream_id"),
("device_lists_remote_pending", "stream_id"),
], ],
is_writer=hs.config.worker.worker_app is None, is_writer=hs.config.worker.worker_app is None,
) )