Remove duplicate session check in web fallback servlet (#6702)

2020-01-15 18:05:18 +00:00 · 2020-01-15 18:05:18 +00:00 · edc244eec4
parent 608bf7d741
commit edc244eec4
2 changed files with 1 additions and 4 deletions
--- a/changelog.d/6702.misc
+++ b/changelog.d/6702.misc
@ -0,0 +1 @@
+Remove duplicate check for the `session` query parameter on the `/auth/xxx/fallback/web` Client-Server endpoint.
--- a/synapse/rest/client/v2_alpha/auth.py
+++ b/synapse/rest/client/v2_alpha/auth.py
@ -206,10 +206,6 @@ class AuthRestServlet(RestServlet):

            return None
        elif stagetype == LoginType.TERMS:
-            if ("session" not in request.args or len(request.args["session"])) == 0:
-                raise SynapseError(400, "No session supplied")
-
-            session = request.args["session"][0]
            authdict = {"session": session}

            success = await self.auth_handler.add_oob_auth(
				`@ -0,0 +1 @@`
				Remove duplicate check for the `session` query parameter on the `/auth/xxx/fallback/web` Client-Server endpoint.