Mirrors
/
synapse-old
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use cache.pop() instead of a separate membership test + del []

This commit is contained in:
Paul "LeoNerd" Evans 2015-02-23 18:29:26 +00:00
parent 27080698e7
commit f53fcbce97
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
synapse/storage/_base.py
View File

@ -75,8 +75,7 @@ def cached(max_entries=1000):
defer.returnValue(ret) defer.returnValue(ret)
def invalidate(key): def invalidate(key):
if key in cache: cache.pop(key, None)
del cache[key]
wrapped.invalidate = invalidate wrapped.invalidate = invalidate
wrapped.prefill = prefill wrapped.prefill = prefill

7
tests/storage/test__base.py
View File

@ -66,6 +66,13 @@ class CacheDecoratorTestCase(unittest.TestCase):
self.assertEquals(callcount[0], 2) self.assertEquals(callcount[0], 2)
def test_invalidate_missing(self):
@cached()
def func(self, key):
return key
func.invalidate("what")
@defer.inlineCallbacks @defer.inlineCallbacks
def test_max_entries(self): def test_max_entries(self):
callcount = [0] callcount = [0]