2018-11-19 11:27:33 -07:00
|
|
|
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright 2018 New Vector
|
2021-01-13 13:21:55 -07:00
|
|
|
# Copyright 2020-2021 The Matrix.org Foundation C.I.C
|
2018-11-19 11:27:33 -07:00
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
2020-12-18 05:33:57 -07:00
|
|
|
from typing import Union
|
2018-11-19 11:27:33 -07:00
|
|
|
|
|
|
|
from twisted.internet.defer import succeed
|
|
|
|
|
2019-05-01 08:32:38 -06:00
|
|
|
import synapse.rest.admin
|
2018-11-19 11:27:33 -07:00
|
|
|
from synapse.api.constants import LoginType
|
2019-09-25 04:33:03 -06:00
|
|
|
from synapse.handlers.ui_auth.checkers import UserInteractiveAuthChecker
|
2020-05-08 14:08:58 -06:00
|
|
|
from synapse.rest.client.v1 import login
|
|
|
|
from synapse.rest.client.v2_alpha import auth, devices, register
|
2020-11-30 17:15:36 -07:00
|
|
|
from synapse.rest.oidc import OIDCResource
|
|
|
|
from synapse.types import JsonDict, UserID
|
2018-11-19 11:27:33 -07:00
|
|
|
|
|
|
|
from tests import unittest
|
2021-01-07 04:41:28 -07:00
|
|
|
from tests.handlers.test_oidc import HAS_OIDC
|
2020-11-30 17:15:36 -07:00
|
|
|
from tests.rest.client.v1.utils import TEST_OIDC_CONFIG
|
2020-05-08 14:08:58 -06:00
|
|
|
from tests.server import FakeChannel
|
2021-01-07 04:41:28 -07:00
|
|
|
from tests.unittest import override_config, skip_unless
|
2018-11-19 11:27:33 -07:00
|
|
|
|
|
|
|
|
2019-09-25 04:33:03 -06:00
|
|
|
class DummyRecaptchaChecker(UserInteractiveAuthChecker):
|
|
|
|
def __init__(self, hs):
|
|
|
|
super().__init__(hs)
|
|
|
|
self.recaptcha_attempts = []
|
|
|
|
|
|
|
|
def check_auth(self, authdict, clientip):
|
|
|
|
self.recaptcha_attempts.append((authdict, clientip))
|
|
|
|
return succeed(True)
|
|
|
|
|
|
|
|
|
2018-11-19 11:27:33 -07:00
|
|
|
class FallbackAuthTests(unittest.HomeserverTestCase):
|
|
|
|
|
|
|
|
servlets = [
|
|
|
|
auth.register_servlets,
|
|
|
|
register.register_servlets,
|
|
|
|
]
|
|
|
|
hijack_auth = False
|
|
|
|
|
|
|
|
def make_homeserver(self, reactor, clock):
|
|
|
|
|
|
|
|
config = self.default_config()
|
|
|
|
|
2019-05-13 14:01:14 -06:00
|
|
|
config["enable_registration_captcha"] = True
|
|
|
|
config["recaptcha_public_key"] = "brokencake"
|
|
|
|
config["registrations_require_3pid"] = []
|
2018-11-19 11:27:33 -07:00
|
|
|
|
|
|
|
hs = self.setup_test_homeserver(config=config)
|
|
|
|
return hs
|
|
|
|
|
|
|
|
def prepare(self, reactor, clock, hs):
|
2019-09-25 04:33:03 -06:00
|
|
|
self.recaptcha_checker = DummyRecaptchaChecker(hs)
|
2018-11-19 11:27:33 -07:00
|
|
|
auth_handler = hs.get_auth_handler()
|
2019-09-25 04:33:03 -06:00
|
|
|
auth_handler.checkers[LoginType.RECAPTCHA] = self.recaptcha_checker
|
2018-11-19 11:27:33 -07:00
|
|
|
|
2020-05-08 14:08:58 -06:00
|
|
|
def register(self, expected_response: int, body: JsonDict) -> FakeChannel:
|
|
|
|
"""Make a register request."""
|
2020-12-15 07:44:04 -07:00
|
|
|
channel = self.make_request("POST", "register", body)
|
2018-11-19 11:27:33 -07:00
|
|
|
|
2020-12-15 07:51:25 -07:00
|
|
|
self.assertEqual(channel.code, expected_response)
|
2020-05-08 14:08:58 -06:00
|
|
|
return channel
|
|
|
|
|
|
|
|
def recaptcha(
|
|
|
|
self, session: str, expected_post_response: int, post_session: str = None
|
|
|
|
) -> None:
|
|
|
|
"""Get and respond to a fallback recaptcha. Returns the second request."""
|
|
|
|
if post_session is None:
|
|
|
|
post_session = session
|
2018-11-19 11:27:33 -07:00
|
|
|
|
2020-12-15 07:44:04 -07:00
|
|
|
channel = self.make_request(
|
2018-11-19 11:27:33 -07:00
|
|
|
"GET", "auth/m.login.recaptcha/fallback/web?session=" + session
|
2020-12-15 07:44:04 -07:00
|
|
|
)
|
2020-12-15 07:51:25 -07:00
|
|
|
self.assertEqual(channel.code, 200)
|
2018-11-19 11:27:33 -07:00
|
|
|
|
2020-12-15 07:44:04 -07:00
|
|
|
channel = self.make_request(
|
2018-11-19 11:27:33 -07:00
|
|
|
"POST",
|
|
|
|
"auth/m.login.recaptcha/fallback/web?session="
|
2020-05-08 14:08:58 -06:00
|
|
|
+ post_session
|
2018-11-19 11:27:33 -07:00
|
|
|
+ "&g-recaptcha-response=a",
|
|
|
|
)
|
2020-12-15 07:51:25 -07:00
|
|
|
self.assertEqual(channel.code, expected_post_response)
|
2018-11-19 11:27:33 -07:00
|
|
|
|
|
|
|
# The recaptcha handler is called with the response given
|
2019-09-25 04:33:03 -06:00
|
|
|
attempts = self.recaptcha_checker.recaptcha_attempts
|
|
|
|
self.assertEqual(len(attempts), 1)
|
|
|
|
self.assertEqual(attempts[0][0]["response"], "a")
|
2018-11-19 11:27:33 -07:00
|
|
|
|
2020-05-08 14:08:58 -06:00
|
|
|
def test_fallback_captcha(self):
|
|
|
|
"""Ensure that fallback auth via a captcha works."""
|
|
|
|
# Returns a 401 as per the spec
|
|
|
|
channel = self.register(
|
|
|
|
401, {"username": "user", "type": "m.login.password", "password": "bar"},
|
2019-05-13 08:34:11 -06:00
|
|
|
)
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
# Grab the session
|
|
|
|
session = channel.json_body["session"]
|
|
|
|
# Assert our configured public key is being given
|
|
|
|
self.assertEqual(
|
|
|
|
channel.json_body["params"]["m.login.recaptcha"]["public_key"], "brokencake"
|
|
|
|
)
|
|
|
|
|
|
|
|
# Complete the recaptcha step.
|
|
|
|
self.recaptcha(session, 200)
|
|
|
|
|
|
|
|
# also complete the dummy auth
|
|
|
|
self.register(200, {"auth": {"session": session, "type": "m.login.dummy"}})
|
2019-05-13 08:34:11 -06:00
|
|
|
|
2020-03-26 05:39:34 -06:00
|
|
|
# Now we should have fulfilled a complete auth flow, including
|
2019-05-13 08:34:11 -06:00
|
|
|
# the recaptcha fallback step, we can then send a
|
2018-11-19 11:27:33 -07:00
|
|
|
# request to the register API with the session in the authdict.
|
2020-05-08 14:08:58 -06:00
|
|
|
channel = self.register(200, {"auth": {"session": session}})
|
2018-11-19 11:27:33 -07:00
|
|
|
|
|
|
|
# We're given a registered user.
|
|
|
|
self.assertEqual(channel.json_body["user_id"], "@user:test")
|
2020-03-26 05:39:34 -06:00
|
|
|
|
2020-04-30 11:47:49 -06:00
|
|
|
def test_complete_operation_unknown_session(self):
|
|
|
|
"""
|
|
|
|
Attempting to mark an invalid session as complete should error.
|
|
|
|
"""
|
|
|
|
# Make the initial request to register. (Later on a different password
|
|
|
|
# will be used.)
|
2020-05-08 14:08:58 -06:00
|
|
|
# Returns a 401 as per the spec
|
|
|
|
channel = self.register(
|
|
|
|
401, {"username": "user", "type": "m.login.password", "password": "bar"}
|
2020-04-30 11:47:49 -06:00
|
|
|
)
|
|
|
|
|
|
|
|
# Grab the session
|
|
|
|
session = channel.json_body["session"]
|
|
|
|
# Assert our configured public key is being given
|
|
|
|
self.assertEqual(
|
|
|
|
channel.json_body["params"]["m.login.recaptcha"]["public_key"], "brokencake"
|
|
|
|
)
|
|
|
|
|
2020-05-08 14:08:58 -06:00
|
|
|
# Attempt to complete the recaptcha step with an unknown session.
|
|
|
|
# This results in an error.
|
|
|
|
self.recaptcha(session, 400, session + "unknown")
|
|
|
|
|
|
|
|
|
|
|
|
class UIAuthTests(unittest.HomeserverTestCase):
|
|
|
|
servlets = [
|
|
|
|
auth.register_servlets,
|
|
|
|
devices.register_servlets,
|
|
|
|
login.register_servlets,
|
|
|
|
synapse.rest.admin.register_servlets_for_client_rest_resource,
|
|
|
|
register.register_servlets,
|
|
|
|
]
|
|
|
|
|
2020-11-30 17:15:36 -07:00
|
|
|
def default_config(self):
|
|
|
|
config = super().default_config()
|
2021-01-07 04:41:28 -07:00
|
|
|
config["public_baseurl"] = "https://synapse.test"
|
2020-11-30 17:15:36 -07:00
|
|
|
|
2021-01-07 04:41:28 -07:00
|
|
|
if HAS_OIDC:
|
|
|
|
# we enable OIDC as a way of testing SSO flows
|
|
|
|
oidc_config = {}
|
|
|
|
oidc_config.update(TEST_OIDC_CONFIG)
|
|
|
|
oidc_config["allow_existing_users"] = True
|
|
|
|
config["oidc_config"] = oidc_config
|
2020-11-30 17:15:36 -07:00
|
|
|
|
|
|
|
return config
|
|
|
|
|
|
|
|
def create_resource_dict(self):
|
|
|
|
resource_dict = super().create_resource_dict()
|
2021-01-07 04:41:28 -07:00
|
|
|
if HAS_OIDC:
|
|
|
|
# mount the OIDC resource at /_synapse/oidc
|
|
|
|
resource_dict["/_synapse/oidc"] = OIDCResource(self.hs)
|
2020-11-30 17:15:36 -07:00
|
|
|
return resource_dict
|
|
|
|
|
2020-05-08 14:08:58 -06:00
|
|
|
def prepare(self, reactor, clock, hs):
|
|
|
|
self.user_pass = "pass"
|
|
|
|
self.user = self.register_user("test", self.user_pass)
|
2020-12-18 05:33:57 -07:00
|
|
|
self.device_id = "dev1"
|
|
|
|
self.user_tok = self.login("test", self.user_pass, self.device_id)
|
2020-04-30 11:47:49 -06:00
|
|
|
|
2020-05-08 14:08:58 -06:00
|
|
|
def delete_device(
|
2020-11-30 17:15:36 -07:00
|
|
|
self,
|
|
|
|
access_token: str,
|
|
|
|
device: str,
|
|
|
|
expected_response: int,
|
|
|
|
body: Union[bytes, JsonDict] = b"",
|
2020-05-08 14:08:58 -06:00
|
|
|
) -> FakeChannel:
|
|
|
|
"""Delete an individual device."""
|
2020-12-15 07:44:04 -07:00
|
|
|
channel = self.make_request(
|
2020-11-30 17:15:36 -07:00
|
|
|
"DELETE", "devices/" + device, body, access_token=access_token,
|
2020-12-15 07:44:04 -07:00
|
|
|
)
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
# Ensure the response is sane.
|
2020-12-15 07:51:25 -07:00
|
|
|
self.assertEqual(channel.code, expected_response)
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
return channel
|
|
|
|
|
|
|
|
def delete_devices(self, expected_response: int, body: JsonDict) -> FakeChannel:
|
|
|
|
"""Delete 1 or more devices."""
|
|
|
|
# Note that this uses the delete_devices endpoint so that we can modify
|
|
|
|
# the payload half-way through some tests.
|
2020-12-15 07:44:04 -07:00
|
|
|
channel = self.make_request(
|
2020-05-08 14:08:58 -06:00
|
|
|
"POST", "delete_devices", body, access_token=self.user_tok,
|
2020-12-15 07:44:04 -07:00
|
|
|
)
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
# Ensure the response is sane.
|
2020-12-15 07:51:25 -07:00
|
|
|
self.assertEqual(channel.code, expected_response)
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
return channel
|
|
|
|
|
|
|
|
def test_ui_auth(self):
|
|
|
|
"""
|
|
|
|
Test user interactive authentication outside of registration.
|
|
|
|
"""
|
|
|
|
# Attempt to delete this device.
|
|
|
|
# Returns a 401 as per the spec
|
2020-12-18 05:33:57 -07:00
|
|
|
channel = self.delete_device(self.user_tok, self.device_id, 401)
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
# Grab the session
|
|
|
|
session = channel.json_body["session"]
|
|
|
|
# Ensure that flows are what is expected.
|
|
|
|
self.assertIn({"stages": ["m.login.password"]}, channel.json_body["flows"])
|
|
|
|
|
|
|
|
# Make another request providing the UI auth flow.
|
|
|
|
self.delete_device(
|
2020-11-30 17:15:36 -07:00
|
|
|
self.user_tok,
|
2020-12-18 05:33:57 -07:00
|
|
|
self.device_id,
|
2020-05-08 14:08:58 -06:00
|
|
|
200,
|
|
|
|
{
|
|
|
|
"auth": {
|
|
|
|
"type": "m.login.password",
|
|
|
|
"identifier": {"type": "m.id.user", "user": self.user},
|
|
|
|
"password": self.user_pass,
|
|
|
|
"session": session,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
2020-12-01 10:42:26 -07:00
|
|
|
def test_grandfathered_identifier(self):
|
|
|
|
"""Check behaviour without "identifier" dict
|
|
|
|
|
|
|
|
Synapse used to require clients to submit a "user" field for m.login.password
|
|
|
|
UIA - check that still works.
|
|
|
|
"""
|
|
|
|
|
2020-12-18 05:33:57 -07:00
|
|
|
channel = self.delete_device(self.user_tok, self.device_id, 401)
|
2020-12-01 10:42:26 -07:00
|
|
|
session = channel.json_body["session"]
|
|
|
|
|
|
|
|
# Make another request providing the UI auth flow.
|
|
|
|
self.delete_device(
|
2020-11-30 17:15:36 -07:00
|
|
|
self.user_tok,
|
2020-12-18 05:33:57 -07:00
|
|
|
self.device_id,
|
2020-12-01 10:42:26 -07:00
|
|
|
200,
|
|
|
|
{
|
|
|
|
"auth": {
|
|
|
|
"type": "m.login.password",
|
|
|
|
"user": self.user,
|
|
|
|
"password": self.user_pass,
|
|
|
|
"session": session,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
2020-05-13 12:26:44 -06:00
|
|
|
def test_can_change_body(self):
|
2020-05-08 14:08:58 -06:00
|
|
|
"""
|
2020-05-13 12:26:44 -06:00
|
|
|
The client dict can be modified during the user interactive authentication session.
|
|
|
|
|
|
|
|
Note that it is not spec compliant to modify the client dict during a
|
|
|
|
user interactive authentication session, but many clients currently do.
|
|
|
|
|
|
|
|
When Synapse is updated to be spec compliant, the call to re-use the
|
|
|
|
session ID should be rejected.
|
2020-05-08 14:08:58 -06:00
|
|
|
"""
|
|
|
|
# Create a second login.
|
2020-12-18 05:33:57 -07:00
|
|
|
self.login("test", self.user_pass, "dev2")
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
# Attempt to delete the first device.
|
|
|
|
# Returns a 401 as per the spec
|
2020-12-18 05:33:57 -07:00
|
|
|
channel = self.delete_devices(401, {"devices": [self.device_id]})
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
# Grab the session
|
|
|
|
session = channel.json_body["session"]
|
|
|
|
# Ensure that flows are what is expected.
|
|
|
|
self.assertIn({"stages": ["m.login.password"]}, channel.json_body["flows"])
|
|
|
|
|
|
|
|
# Make another request providing the UI auth flow, but try to delete the
|
2020-05-13 12:26:44 -06:00
|
|
|
# second device.
|
2020-05-08 14:08:58 -06:00
|
|
|
self.delete_devices(
|
2020-05-13 12:26:44 -06:00
|
|
|
200,
|
2020-05-08 14:08:58 -06:00
|
|
|
{
|
2020-12-18 05:33:57 -07:00
|
|
|
"devices": ["dev2"],
|
2020-05-08 14:08:58 -06:00
|
|
|
"auth": {
|
|
|
|
"type": "m.login.password",
|
|
|
|
"identifier": {"type": "m.id.user", "user": self.user},
|
|
|
|
"password": self.user_pass,
|
|
|
|
"session": session,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
def test_cannot_change_uri(self):
|
|
|
|
"""
|
|
|
|
The initial requested URI cannot be modified during the user interactive authentication session.
|
|
|
|
"""
|
|
|
|
# Create a second login.
|
2020-12-18 05:33:57 -07:00
|
|
|
self.login("test", self.user_pass, "dev2")
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
# Attempt to delete the first device.
|
|
|
|
# Returns a 401 as per the spec
|
2020-12-18 05:33:57 -07:00
|
|
|
channel = self.delete_device(self.user_tok, self.device_id, 401)
|
2020-05-08 14:08:58 -06:00
|
|
|
|
|
|
|
# Grab the session
|
|
|
|
session = channel.json_body["session"]
|
|
|
|
# Ensure that flows are what is expected.
|
|
|
|
self.assertIn({"stages": ["m.login.password"]}, channel.json_body["flows"])
|
|
|
|
|
|
|
|
# Make another request providing the UI auth flow, but try to delete the
|
|
|
|
# second device. This results in an error.
|
2020-12-18 05:33:57 -07:00
|
|
|
#
|
|
|
|
# This makes use of the fact that the device ID is embedded into the URL.
|
2020-05-08 14:08:58 -06:00
|
|
|
self.delete_device(
|
2020-11-30 17:15:36 -07:00
|
|
|
self.user_tok,
|
2020-12-18 05:33:57 -07:00
|
|
|
"dev2",
|
2020-05-08 14:08:58 -06:00
|
|
|
403,
|
|
|
|
{
|
|
|
|
"auth": {
|
|
|
|
"type": "m.login.password",
|
|
|
|
"identifier": {"type": "m.id.user", "user": self.user},
|
|
|
|
"password": self.user_pass,
|
|
|
|
"session": session,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
2020-11-30 17:15:36 -07:00
|
|
|
|
2020-12-18 05:33:57 -07:00
|
|
|
@unittest.override_config({"ui_auth": {"session_timeout": 5 * 1000}})
|
|
|
|
def test_can_reuse_session(self):
|
|
|
|
"""
|
|
|
|
The session can be reused if configured.
|
|
|
|
|
|
|
|
Compare to test_cannot_change_uri.
|
|
|
|
"""
|
|
|
|
# Create a second and third login.
|
|
|
|
self.login("test", self.user_pass, "dev2")
|
|
|
|
self.login("test", self.user_pass, "dev3")
|
|
|
|
|
|
|
|
# Attempt to delete a device. This works since the user just logged in.
|
|
|
|
self.delete_device(self.user_tok, "dev2", 200)
|
|
|
|
|
|
|
|
# Move the clock forward past the validation timeout.
|
|
|
|
self.reactor.advance(6)
|
|
|
|
|
|
|
|
# Deleting another devices throws the user into UI auth.
|
|
|
|
channel = self.delete_device(self.user_tok, "dev3", 401)
|
|
|
|
|
|
|
|
# Grab the session
|
|
|
|
session = channel.json_body["session"]
|
|
|
|
# Ensure that flows are what is expected.
|
|
|
|
self.assertIn({"stages": ["m.login.password"]}, channel.json_body["flows"])
|
|
|
|
|
|
|
|
# Make another request providing the UI auth flow.
|
|
|
|
self.delete_device(
|
|
|
|
self.user_tok,
|
|
|
|
"dev3",
|
|
|
|
200,
|
|
|
|
{
|
|
|
|
"auth": {
|
|
|
|
"type": "m.login.password",
|
|
|
|
"identifier": {"type": "m.id.user", "user": self.user},
|
|
|
|
"password": self.user_pass,
|
|
|
|
"session": session,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
# Make another request, but try to delete the first device. This works
|
|
|
|
# due to re-using the previous session.
|
|
|
|
#
|
|
|
|
# Note that *no auth* information is provided, not even a session iD!
|
|
|
|
self.delete_device(self.user_tok, self.device_id, 200)
|
|
|
|
|
2021-01-13 13:21:55 -07:00
|
|
|
@skip_unless(HAS_OIDC, "requires OIDC")
|
|
|
|
@override_config({"oidc_config": TEST_OIDC_CONFIG})
|
|
|
|
def test_ui_auth_via_sso(self):
|
|
|
|
"""Test a successful UI Auth flow via SSO
|
|
|
|
|
|
|
|
This includes:
|
|
|
|
* hitting the UIA SSO redirect endpoint
|
|
|
|
* checking it serves a confirmation page which links to the OIDC provider
|
|
|
|
* calling back to the synapse oidc callback
|
|
|
|
* checking that the original operation succeeds
|
|
|
|
"""
|
|
|
|
|
|
|
|
# log the user in
|
|
|
|
remote_user_id = UserID.from_string(self.user).localpart
|
|
|
|
login_resp = self.helper.login_via_oidc(remote_user_id)
|
|
|
|
self.assertEqual(login_resp["user_id"], self.user)
|
|
|
|
|
|
|
|
# initiate a UI Auth process by attempting to delete the device
|
|
|
|
channel = self.delete_device(self.user_tok, self.device_id, 401)
|
|
|
|
|
|
|
|
# check that SSO is offered
|
|
|
|
flows = channel.json_body["flows"]
|
|
|
|
self.assertIn({"stages": ["m.login.sso"]}, flows)
|
|
|
|
|
|
|
|
# run the UIA-via-SSO flow
|
|
|
|
session_id = channel.json_body["session"]
|
|
|
|
channel = self.helper.auth_via_oidc(
|
|
|
|
remote_user_id=remote_user_id, ui_auth_session_id=session_id
|
|
|
|
)
|
|
|
|
|
|
|
|
# that should serve a confirmation page
|
|
|
|
self.assertEqual(channel.code, 200, channel.result)
|
|
|
|
|
|
|
|
# and now the delete request should succeed.
|
|
|
|
self.delete_device(
|
|
|
|
self.user_tok, self.device_id, 200, body={"auth": {"session": session_id}},
|
|
|
|
)
|
|
|
|
|
2021-01-07 04:41:28 -07:00
|
|
|
@skip_unless(HAS_OIDC, "requires OIDC")
|
|
|
|
@override_config({"oidc_config": TEST_OIDC_CONFIG})
|
2020-11-30 17:15:36 -07:00
|
|
|
def test_does_not_offer_password_for_sso_user(self):
|
|
|
|
login_resp = self.helper.login_via_oidc("username")
|
|
|
|
user_tok = login_resp["access_token"]
|
|
|
|
device_id = login_resp["device_id"]
|
|
|
|
|
|
|
|
# now call the device deletion API: we should get the option to auth with SSO
|
|
|
|
# and not password.
|
|
|
|
channel = self.delete_device(user_tok, device_id, 401)
|
|
|
|
|
|
|
|
flows = channel.json_body["flows"]
|
|
|
|
self.assertEqual(flows, [{"stages": ["m.login.sso"]}])
|
|
|
|
|
|
|
|
def test_does_not_offer_sso_for_password_user(self):
|
2020-12-18 05:33:57 -07:00
|
|
|
channel = self.delete_device(self.user_tok, self.device_id, 401)
|
2020-11-30 17:15:36 -07:00
|
|
|
|
|
|
|
flows = channel.json_body["flows"]
|
|
|
|
self.assertEqual(flows, [{"stages": ["m.login.password"]}])
|
|
|
|
|
2021-01-07 04:41:28 -07:00
|
|
|
@skip_unless(HAS_OIDC, "requires OIDC")
|
|
|
|
@override_config({"oidc_config": TEST_OIDC_CONFIG})
|
2020-11-30 17:15:36 -07:00
|
|
|
def test_offers_both_flows_for_upgraded_user(self):
|
|
|
|
"""A user that had a password and then logged in with SSO should get both flows
|
|
|
|
"""
|
|
|
|
login_resp = self.helper.login_via_oidc(UserID.from_string(self.user).localpart)
|
|
|
|
self.assertEqual(login_resp["user_id"], self.user)
|
|
|
|
|
2020-12-18 05:33:57 -07:00
|
|
|
channel = self.delete_device(self.user_tok, self.device_id, 401)
|
2020-11-30 17:15:36 -07:00
|
|
|
|
|
|
|
flows = channel.json_body["flows"]
|
|
|
|
# we have no particular expectations of ordering here
|
|
|
|
self.assertIn({"stages": ["m.login.password"]}, flows)
|
|
|
|
self.assertIn({"stages": ["m.login.sso"]}, flows)
|
|
|
|
self.assertEqual(len(flows), 2)
|
2021-01-13 05:35:23 -07:00
|
|
|
|
|
|
|
@skip_unless(HAS_OIDC, "requires OIDC")
|
|
|
|
@override_config({"oidc_config": TEST_OIDC_CONFIG})
|
|
|
|
def test_ui_auth_fails_for_incorrect_sso_user(self):
|
|
|
|
"""If the user tries to authenticate with the wrong SSO user, they get an error
|
|
|
|
"""
|
|
|
|
# log the user in
|
|
|
|
login_resp = self.helper.login_via_oidc(UserID.from_string(self.user).localpart)
|
|
|
|
self.assertEqual(login_resp["user_id"], self.user)
|
|
|
|
|
|
|
|
# start a UI Auth flow by attempting to delete a device
|
|
|
|
channel = self.delete_device(self.user_tok, self.device_id, 401)
|
|
|
|
|
|
|
|
flows = channel.json_body["flows"]
|
|
|
|
self.assertIn({"stages": ["m.login.sso"]}, flows)
|
|
|
|
session_id = channel.json_body["session"]
|
|
|
|
|
|
|
|
# do the OIDC auth, but auth as the wrong user
|
|
|
|
channel = self.helper.auth_via_oidc("wrong_user", ui_auth_session_id=session_id)
|
|
|
|
|
|
|
|
# that should return a failure message
|
|
|
|
self.assertSubstring("We were unable to validate", channel.text_body)
|
|
|
|
|
|
|
|
# ... and the delete op should now fail with a 403
|
|
|
|
self.delete_device(
|
|
|
|
self.user_tok, self.device_id, 403, body={"auth": {"session": session_id}}
|
|
|
|
)
|