2023-01-11 11:36:41 -07:00
|
|
|
# Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
2022-10-06 07:00:03 -06:00
|
|
|
from unittest.mock import patch
|
|
|
|
|
2023-01-11 11:36:41 -07:00
|
|
|
from twisted.test.proto_helpers import MemoryReactor
|
|
|
|
|
2022-10-06 07:00:03 -06:00
|
|
|
from synapse.api.room_versions import RoomVersions
|
|
|
|
from synapse.push.bulk_push_rule_evaluator import BulkPushRuleEvaluator
|
|
|
|
from synapse.rest import admin
|
|
|
|
from synapse.rest.client import login, register, room
|
2023-01-11 11:36:41 -07:00
|
|
|
from synapse.server import HomeServer
|
2022-10-06 07:00:03 -06:00
|
|
|
from synapse.types import create_requester
|
2023-01-11 11:36:41 -07:00
|
|
|
from synapse.util import Clock
|
2022-10-06 07:00:03 -06:00
|
|
|
|
2022-12-01 06:46:24 -07:00
|
|
|
from tests.test_utils import simple_async_mock
|
|
|
|
from tests.unittest import HomeserverTestCase, override_config
|
2022-10-06 07:00:03 -06:00
|
|
|
|
|
|
|
|
2022-12-01 06:46:24 -07:00
|
|
|
class TestBulkPushRuleEvaluator(HomeserverTestCase):
|
2022-10-06 07:00:03 -06:00
|
|
|
|
|
|
|
servlets = [
|
|
|
|
admin.register_servlets_for_client_rest_resource,
|
|
|
|
room.register_servlets,
|
|
|
|
login.register_servlets,
|
|
|
|
register.register_servlets,
|
|
|
|
]
|
|
|
|
|
2023-01-11 11:36:41 -07:00
|
|
|
def prepare(
|
|
|
|
self, reactor: MemoryReactor, clock: Clock, homeserver: HomeServer
|
|
|
|
) -> None:
|
|
|
|
# Create a new user and room.
|
|
|
|
self.alice = self.register_user("alice", "pass")
|
|
|
|
self.token = self.login(self.alice, "pass")
|
|
|
|
self.requester = create_requester(self.alice)
|
|
|
|
|
|
|
|
self.room_id = self.helper.create_room_as(
|
|
|
|
self.alice, room_version=RoomVersions.V9.identifier, tok=self.token
|
|
|
|
)
|
|
|
|
|
|
|
|
self.event_creation_handler = self.hs.get_event_creation_handler()
|
|
|
|
|
2022-10-06 07:00:03 -06:00
|
|
|
def test_action_for_event_by_user_handles_noninteger_power_levels(self) -> None:
|
|
|
|
"""We should convert floats and strings to integers before passing to Rust.
|
|
|
|
|
|
|
|
Reproduces #14060.
|
|
|
|
|
|
|
|
A lack of validation: the gift that keeps on giving.
|
|
|
|
"""
|
|
|
|
|
|
|
|
# Alter the power levels in that room to include stringy and floaty levels.
|
|
|
|
# We need to suppress the validation logic or else it will reject these dodgy
|
|
|
|
# values. (Presumably this validation was not always present.)
|
|
|
|
with patch("synapse.events.validator.validate_canonicaljson"), patch(
|
|
|
|
"synapse.events.validator.jsonschema.validate"
|
|
|
|
):
|
|
|
|
self.helper.send_state(
|
2023-01-11 11:36:41 -07:00
|
|
|
self.room_id,
|
2022-10-06 07:00:03 -06:00
|
|
|
"m.room.power_levels",
|
|
|
|
{
|
2023-01-11 11:36:41 -07:00
|
|
|
"users": {self.alice: "100"}, # stringy
|
2022-10-06 07:00:03 -06:00
|
|
|
"notifications": {"room": 100.0}, # float
|
|
|
|
},
|
2023-01-11 11:36:41 -07:00
|
|
|
self.token,
|
2022-10-06 07:00:03 -06:00
|
|
|
state_key="",
|
|
|
|
)
|
|
|
|
|
|
|
|
# Create a new message event, and try to evaluate it under the dodgy
|
|
|
|
# power level event.
|
|
|
|
event, context = self.get_success(
|
2023-01-11 11:36:41 -07:00
|
|
|
self.event_creation_handler.create_event(
|
|
|
|
self.requester,
|
2022-10-06 07:00:03 -06:00
|
|
|
{
|
|
|
|
"type": "m.room.message",
|
2023-01-11 11:36:41 -07:00
|
|
|
"room_id": self.room_id,
|
2022-10-06 07:00:03 -06:00
|
|
|
"content": {
|
|
|
|
"msgtype": "m.text",
|
|
|
|
"body": "helo",
|
|
|
|
},
|
2023-01-11 11:36:41 -07:00
|
|
|
"sender": self.alice,
|
2022-10-06 07:00:03 -06:00
|
|
|
},
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
bulk_evaluator = BulkPushRuleEvaluator(self.hs)
|
|
|
|
# should not raise
|
2022-10-21 11:46:22 -06:00
|
|
|
self.get_success(bulk_evaluator.action_for_events_by_user([(event, context)]))
|
2022-12-01 06:46:24 -07:00
|
|
|
|
|
|
|
@override_config({"push": {"enabled": False}})
|
|
|
|
def test_action_for_event_by_user_disabled_by_config(self) -> None:
|
|
|
|
"""Ensure that push rules are not calculated when disabled in the config"""
|
|
|
|
|
2023-01-11 11:36:41 -07:00
|
|
|
# Create a new message event which should cause a notification.
|
2022-12-01 06:46:24 -07:00
|
|
|
event, context = self.get_success(
|
2023-01-11 11:36:41 -07:00
|
|
|
self.event_creation_handler.create_event(
|
|
|
|
self.requester,
|
2022-12-01 06:46:24 -07:00
|
|
|
{
|
|
|
|
"type": "m.room.message",
|
2023-01-11 11:36:41 -07:00
|
|
|
"room_id": self.room_id,
|
2022-12-01 06:46:24 -07:00
|
|
|
"content": {
|
|
|
|
"msgtype": "m.text",
|
|
|
|
"body": "helo",
|
|
|
|
},
|
2023-01-11 11:36:41 -07:00
|
|
|
"sender": self.alice,
|
2022-12-01 06:46:24 -07:00
|
|
|
},
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
bulk_evaluator = BulkPushRuleEvaluator(self.hs)
|
2023-01-11 11:36:41 -07:00
|
|
|
# Mock the method which calculates push rules -- we do this instead of
|
|
|
|
# e.g. checking the results in the database because we want to ensure
|
|
|
|
# that code isn't even running.
|
2022-12-01 06:46:24 -07:00
|
|
|
bulk_evaluator._action_for_event_by_user = simple_async_mock() # type: ignore[assignment]
|
2023-01-11 11:36:41 -07:00
|
|
|
|
|
|
|
# Ensure no actions are generated!
|
2022-12-01 06:46:24 -07:00
|
|
|
self.get_success(bulk_evaluator.action_for_events_by_user([(event, context)]))
|
|
|
|
bulk_evaluator._action_for_event_by_user.assert_not_called()
|