Check values are strings

2017-07-20 16:24:18 +01:00 · 2017-07-20 16:24:18 +01:00 · 0ab153d201
parent 8209b5f033
commit 0ab153d201
1 changed files with 4 additions and 1 deletions
--- a/synapse/groups/groups_server.py
+++ b/synapse/groups/groups_server.py
@ -353,7 +353,10 @@ class GroupsServerHandler(object):
        for keyname in ("name", "avatar_url", "short_description",
                        "long_description"):
            if keyname in content:
-                profile[keyname] = content[keyname]
+                value = content[keyname]
+                if not isinstance(value, basestring):
+                    raise SynapseError(400, "%r value is not a string" % (keyname,))
+                profile[keyname] = value

        yield self.store.update_group_profile(group_id, profile)