Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Workaround for non-uniqueness of room member events in the database confusing HAVING COUNT() test of room membership intersection (with thanks to Tom Molesworth)

This commit is contained in:
Paul "LeoNerd" Evans 2014-12-02 21:36:53 +00:00
parent 274d137b00
commit 10eb8f070c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
synapse/storage/roommember.py
View File

@ -218,7 +218,9 @@ class RoomMemberStore(SQLBaseStore):
"ON m.event_id = c.event_id " "ON m.event_id = c.event_id "
"WHERE m.membership = 'join' " "WHERE m.membership = 'join' "
"AND (%(clause)s) " "AND (%(clause)s) "
"GROUP BY m.room_id HAVING COUNT(m.room_id) = ?" # TODO(paul): We've got duplicate rows in the database somewhere
# so we have to DISTINCT m.user_id here
"GROUP BY m.room_id HAVING COUNT(DISTINCT m.user_id) = ?"
) % {"clause": user_list_clause} ) % {"clause": user_list_clause}
args = list(user_id_list) args = list(user_id_list)