Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert the general exception recording introduced in #13814 (#13969) 

* Maybe not catch all errors to avoid things in the nature-of CancelledError

See https://github.com/matrix-org/synapse/pull/13815#discussion_r983384698

* Remove general exception tracking

* Add changelog
This commit is contained in:
Eric Eastwood 2022-10-03 04:14:45 -05:00 committed by GitHub
parent a52c40e2a6
commit 2769ef4df1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/13969.misc Normal file
View File

@ -0,0 +1 @@
Revert catch-all exceptions being recorded as event pull attempt failures (only handle what we know about).

10
synapse/handlers/federation_event.py
View File

@ -866,11 +866,6 @@ class FederationEventHandler:
event.room_id, event_id, str(err) event.room_id, event_id, str(err)
) )
return return
except Exception as exc:
await self._store.record_event_failed_pull_attempt(
event.room_id, event_id, str(exc)
)
raise exc
try: try:
try: try:
@ -913,11 +908,6 @@ class FederationEventHandler:
logger.warning("Pulled event %s failed history check.", event_id) logger.warning("Pulled event %s failed history check.", event_id)
else: else:
raise raise
except Exception as exc:
await self._store.record_event_failed_pull_attempt(
event.room_id, event_id, str(exc)
)
raise exc
@trace @trace
async def _compute_event_context_with_maybe_missing_prevs( async def _compute_event_context_with_maybe_missing_prevs(