Remove unneeded type constraints on 3rd party protocol lookup responses

2021-02-09 17:50:25 +01:00 · 2021-02-09 17:50:25 +01:00 · 29ae04af3b
parent 3f58fc848d
commit 29ae04af3b
2 changed files with 1 additions and 3 deletions
--- a/changelog.d/9361.bugfix
+++ b/changelog.d/9361.bugfix
@ -0,0 +1 @@
+Fix a bug causing Synapse to impose the wrong type constraints on fields when processing responses from appservices to `/_matrix/app/v1/thirdparty/user/{protocol}`.
--- a/synapse/appservice/api.py
+++ b/synapse/appservice/api.py
@ -76,9 +76,6 @@ def _is_valid_3pe_result(r, field):
    fields = r["fields"]
    if not isinstance(fields, dict):
        return False
-    for k in fields.keys():
-        if not isinstance(fields[k], str):
-            return False

    return True
				`@ -0,0 +1 @@`
				Fix a bug causing Synapse to impose the wrong type constraints on fields when processing responses from appservices to `/_matrix/app/v1/thirdparty/user/{protocol}`.