Correct logic for checking private group membership

2017-10-27 10:48:01 +01:00 · 2017-10-27 10:48:01 +01:00 · 2ca46c7afc
parent 69e8a05f35
commit 2ca46c7afc
1 changed files with 1 additions and 1 deletions
--- a/synapse/groups/groups_server.py
+++ b/synapse/groups/groups_server.py
@ -69,7 +69,7 @@ class GroupsServerHandler(object):
            raise SynapseError(404, "Unknown group")

        is_user_in_group = yield self.store.is_user_in_group(requester_user_id, group_id)
-        if not is_user_in_group or not group.is_public:
+        if group and not is_user_in_group and not group.is_public:
            raise SynapseError(404, "Unknown group")

        if and_is_admin: