Merge pull request #1649 from matrix-org/dbkr/log_ui_auth_args

Log the args that we have on UI auth completion
This commit is contained in:
Erik Johnston 2016-12-05 16:40:58 +00:00 committed by GitHub
commit 338df4f409
1 changed files with 9 additions and 1 deletions

View File

@ -162,7 +162,15 @@ class AuthHandler(BaseHandler):
for f in flows:
if len(set(f) - set(creds.keys())) == 0:
logger.info("Auth completed with creds: %r", creds)
# it's very useful to know what args are stored, but this can
# include the password in the case of registering, so only log
# the keys (confusingly, clientdict may contain a password
# param, creds is just what the user authed as for UI auth
# and is not sensitive).
logger.info(
"Auth completed with creds: %r. Client dict has keys: %r",
creds, clientdict.keys()
)
defer.returnValue((True, creds, clientdict, session['id']))
ret = self._auth_dict_for_flows(flows, session)