Use is_outlier() so that we don't get AttributeError

synapse/federation/replication.py

@@ -562,8 +562,8 @@ class ReplicationLayer(object):
 
         already_seen = (
             existing and (
-                not existing.internal_metadata.outlier
+                not existing.internal_metadata.is_outlier()
-                or pdu.internal_metadata.outlier
+                or pdu.internal_metadata.is_outlier()
             )
         )
         if already_seen:
@@ -604,7 +604,7 @@ class ReplicationLayer(object):
         #             )
 
         # Get missing pdus if necessary.
-        if not pdu.internal_metadata.outlier:
+        if not pdu.internal_metadata.is_outlier():
             # We only backfill backwards to the min depth.
             min_depth = yield self.handler.get_min_depth_for_context(
                 pdu.room_id

synapse/state.py

@@ -79,7 +79,7 @@ class StateHandler(object):
             defer.returnValue(False)
             return
 
-        if hasattr(event, "outlier") and event.outlier:
+        if event.is_outlier():
             event.state_group = None
             event.old_state_events = None
             event.state_events = None

synapse/storage/__init__.py

@@ -143,9 +143,7 @@ class DataStore(RoomMemberStore, RoomStore,
         elif event.type == EventTypes.Redaction:
             self._store_redaction(txn, event)
 
-        outlier = False
+        outlier = event.internal_metadata.is_outlier()
-        if hasattr(event.internal_metadata, "outlier"):
-            outlier = event.internal_metadata.outlier
 
         event_dict = {
             k: v