hidden/minimise/focus disaster disclaimer with the TODO

This commit is contained in:
Kegan Dougal 2014-09-16 15:34:33 +01:00
parent b36a0c71d1
commit 5aaa3c09c1
1 changed files with 4 additions and 0 deletions

View File

@ -183,6 +183,10 @@ function(matrixService, $rootScope, $q, $timeout, mPresence) {
var shouldBing = $rootScope.containsBingWord(event.content.body); var shouldBing = $rootScope.containsBingWord(event.content.body);
// TODO: Binging every message when idle doesn't make much sense. Can we use this more sensibly? // TODO: Binging every message when idle doesn't make much sense. Can we use this more sensibly?
// Unfortunately document.hidden = false on ubuntu chrome if chrome is minimised / does not have focus;
// true when you swap tabs though. However, for the case where the chat screen is OPEN and there is
// another window on top, we want to be notifying for those events. This DOES mean that there will be
// notifications when currently viewing the chat screen though, but that is preferable to the alternative imo.
var isIdle = (document.hidden || matrixService.presence.unavailable === mPresence.getState()); var isIdle = (document.hidden || matrixService.presence.unavailable === mPresence.getState());
if (shouldBing) { if (shouldBing) {