Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Limit the size of the aggregation_key (#12101) 

There's no reason to let people use long keys.
This commit is contained in:
Erik Johnston 2022-03-03 10:52:35 +00:00 committed by GitHub
parent 31b125ccec
commit 61fd2a8f59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/12101.misc Normal file
View File

@ -0,0 +1 @@
Limit the size of `aggregation_key` on annotations.

3
synapse/handlers/message.py
View File

@ -1069,6 +1069,9 @@ class EventCreationHandler:
if relation_type == RelationTypes.ANNOTATION: if relation_type == RelationTypes.ANNOTATION:
aggregation_key = relation["key"] aggregation_key = relation["key"]
if len(aggregation_key) > 500:
raise SynapseError(400, "Aggregation key is too long")
already_exists = await self.store.has_user_annotated_event( already_exists = await self.store.has_user_annotated_event(
relates_to, event.type, aggregation_key, event.sender relates_to, event.type, aggregation_key, event.sender
) )