Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fiddle should_notify to better report stats

This commit is contained in:
Erik Johnston 2016-09-06 10:23:38 +01:00
parent 8c93e0bae7
commit 74a3b4a650
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
synapse/handlers/presence.py
View File

@ -945,29 +945,24 @@ def should_notify(old_state, new_state):
notify_reason_counter.inc("status_msg_change")
return True
if old_state.state == PresenceState.ONLINE:
if new_state.state != PresenceState.ONLINE:
# Always notify for online -> anything
notify_reason_counter.inc("online_to_not")
return True
if old_state.state != new_state.state:
notify_reason_counter.inc("state_change")
return True
if old_state.state == PresenceState.ONLINE:
if new_state.currently_active != old_state.currently_active:
notify_reason_counter.inc("current_active_change")
return True
if new_state.last_active_ts - old_state.last_active_ts > LAST_ACTIVE_GRANULARITY:
# Only notify about last active bumps if we're not currently acive
if not (old_state.currently_active and new_state.currently_active):
notify_reason_counter.inc("last_active_change")
if not new_state.currently_active:
notify_reason_counter.inc("last_active_change_online")
return True
elif new_state.last_active_ts - old_state.last_active_ts > LAST_ACTIVE_GRANULARITY:
# Always notify for a transition where last active gets bumped.
notify_reason_counter.inc("last_active_change")
return True
if old_state.state != new_state.state:
notify_reason_counter.inc("state_change")
notify_reason_counter.inc("last_active_change_not_online")
return True
return False