Merge pull request #2529 from matrix-org/rav/fix_transaction_failure_handling

log pdu_failures from incoming transactions

synapse/federation/federation_server.py

@@ -211,7 +211,8 @@ class FederationServer(FederationBase):
                     edu.content
                 )
 
-            for failure in getattr(transaction, "pdu_failures", []):
+        pdu_failures = getattr(transaction, "pdu_failures", [])
+        for failure in pdu_failures:
             logger.info("Got failure %r", failure)
 
         response = {