Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix twisted trunk mypy errors (#14012)

This commit is contained in:
David Robertson 2022-10-03 14:26:49 +01:00 committed by GitHub
parent 7f4f2a3782
commit a423f45294
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/14012.misc Normal file
View File

@ -0,0 +1 @@
Fix type annotations to be compatible with new annotations in development versions of twisted.

3
synapse/handlers/cas.py
View File

@ -130,6 +130,9 @@ class CasHandler:
except PartialDownloadError as pde: except PartialDownloadError as pde:
# Twisted raises this error if the connection is closed, # Twisted raises this error if the connection is closed,
# even if that's being used old-http style to signal end-of-data # even if that's being used old-http style to signal end-of-data
# Assertion is for mypy's benefit. Error.response is Optional[bytes],
# but a PartialDownloadError should always have a non-None response.
assert pde.response is not None
body = pde.response body = pde.response
except HttpResponseException as e: except HttpResponseException as e:
description = ( description = (

3
synapse/handlers/ui_auth/checkers.py
View File

@ -119,6 +119,9 @@ class RecaptchaAuthChecker(UserInteractiveAuthChecker):
except PartialDownloadError as pde: except PartialDownloadError as pde:
# Twisted is silly # Twisted is silly
data = pde.response data = pde.response
# For mypy's benefit. A general Error.response is Optional[bytes], but
# a PartialDownloadError.response should be bytes AFAICS.
assert data is not None
resp_body = json_decoder.decode(data.decode("utf-8")) resp_body = json_decoder.decode(data.decode("utf-8"))
if "success" in resp_body: if "success" in resp_body: