Limit max number of SQL vars

synapse/storage/search.py

@@ -36,10 +36,12 @@ class SearchStore(SQLBaseStore):
         clauses = []
         args = []
 
-        clauses.append(
+        # Make sure we don't explode because the person is in too many rooms.
-            "room_id IN (%s)" % (",".join(["?"] * len(room_ids)),)
+        if len(room_ids) > 500:
-        )
+            clauses.append(
-        args.extend(room_ids)
+                "room_id IN (%s)" % (",".join(["?"] * len(room_ids)),)
+            )
+            args.extend(room_ids)
 
         local_clauses = []
         for key in keys: