Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bug in replication where response is cached (#15024)

This commit is contained in:
Erik Johnston 2023-02-08 17:41:55 +01:00 committed by GitHub
parent d83178a33a
commit c78c67c5a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/15024.bugfix Normal file
View File

@ -0,0 +1 @@
Fix bug where retried replication requests would return a failure. Introduced in v1.76.0.

2
synapse/replication/http/_base.py
View File

@ -426,6 +426,8 @@ class ReplicationEndpoint(metaclass=abc.ABCMeta):
code, response = await self.response_cache.wrap( code, response = await self.response_cache.wrap(
txn_id, self._handle_request, request, content, **kwargs txn_id, self._handle_request, request, content, **kwargs
) )
# Take a copy so we don't mutate things in the cache.
response = dict(response)
else: else:
# The `@cancellable` decorator may be applied to `_handle_request`. But we # The `@cancellable` decorator may be applied to `_handle_request`. But we
# told `HttpServer.register_paths` that our handler is `_check_auth_and_handle`, # told `HttpServer.register_paths` that our handler is `_check_auth_and_handle`,