Log a warning if an AS yields an invalid 3PU lookup result

2016-08-18 15:49:55 +01:00 · 2016-08-18 15:49:55 +01:00 · d7b42afc74
parent 80f4740c8f
commit d7b42afc74
1 changed files with 6 additions and 1 deletions
--- a/synapse/handlers/appservice.py
+++ b/synapse/handlers/appservice.py
@ -184,7 +184,12 @@ class ApplicationServicesHandler(object):
                continue
            if not isinstance(result, list):
                continue
-            ret.extend(r for r in result if _is_valid_3pu_result(r))
+            for r in result:
+                if _is_valid_3pu_result(r):
+                    ret.append(r)
+                else:
+                    logger.warn("Application service returned an " +
+                                "invalid result %r", r)

        defer.returnValue(ret)