Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix failure to fetch batches of PDUs (#5342) 

FederationClient.get_pdu is called in a loop to fetch a batch of PDUs. A
failure to fetch one should not result in a failure of the whole batch. Add the
missing `continue`.
This commit is contained in:
Richard van der Hoff 2019-06-04 18:05:06 +01:00 committed by GitHub
parent b4189b112f
commit dae224a73f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/5342.bugfix Normal file
View File

@ -0,0 +1 @@
Fix failure when fetching batches of events during backfill, etc.

1
synapse/federation/federation_client.py
View File

@ -279,6 +279,7 @@ class FederationClient(FederationBase):
"Failed to get PDU %s from %s because %s", "Failed to get PDU %s from %s because %s",
event_id, destination, e, event_id, destination, e,
) )
continue
except NotRetryingDestination as e: except NotRetryingDestination as e:
logger.info(str(e)) logger.info(str(e))
continue continue