Add comments on min_stream_id

saying that the min stream id won't be completely accurate all the time
This commit is contained in:
David Baker 2016-04-07 17:09:36 +01:00
parent 05d044aac3
commit e1e042f2a1
2 changed files with 3 additions and 0 deletions

View File

@ -111,6 +111,7 @@ class ReceiptsHandler(BaseHandler):
self.notifier.on_new_event( self.notifier.on_new_event(
"receipt_key", max_batch_id, rooms=affected_room_ids "receipt_key", max_batch_id, rooms=affected_room_ids
) )
# Note that the min here shouldn't be relied upon to be accurate.
self.hs.get_pusherpool().on_new_receipts( self.hs.get_pusherpool().on_new_receipts(
min_batch_id, max_batch_id, affected_room_ids min_batch_id, max_batch_id, affected_room_ids
) )

View File

@ -87,6 +87,8 @@ class HttpPusher(object):
@defer.inlineCallbacks @defer.inlineCallbacks
def on_new_receipts(self, min_stream_id, max_stream_id): def on_new_receipts(self, min_stream_id, max_stream_id):
# Note that the min here shouldn't be relied upon to be accurate.
# We could check the receipts are actually m.read receipts here, # We could check the receipts are actually m.read receipts here,
# but currently that's the only type of receipt anyway... # but currently that's the only type of receipt anyway...
badge = yield push_tools.get_badge_count(self.hs, self.user_id) badge = yield push_tools.get_badge_count(self.hs, self.user_id)