Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-Authored-By: Brendan Abolivier <babolivier@matrix.org>
Co-Authored-By: Erik Johnston <erik@matrix.org>
This commit is contained in:
Richard van der Hoff 2019-11-05 16:46:39 +00:00 committed by GitHub
parent e9bfe719ba
commit e78167c94b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
synapse/rest/media/v1/preview_url_resource.py
View File

@ -518,7 +518,7 @@ def _calc_og(tree, media_uri):
if "content" in tag.attrib: if "content" in tag.attrib:
# if we've got more than 50 tags, someone is taking the piss # if we've got more than 50 tags, someone is taking the piss
if len(og) >= 50: if len(og) >= 50:
logger.warning("skipping OG for page with too many og: tags") logger.warning("Skipping OG for page with too many 'og:' tags")
return {} return {}
og[tag.attrib["property"]] = tag.attrib["content"] og[tag.attrib["property"]] = tag.attrib["content"]

1
tests/rest/media/v1/test_url_preview.py
View File

@ -279,6 +279,7 @@ class URLPreviewTests(unittest.HomeserverTestCase):
self.pump() self.pump()
self.assertEqual(channel.code, 200) self.assertEqual(channel.code, 200)
res = channel.json_body res = channel.json_body
# We should only see the `og:description` field, as `title` is too long and should be stripped out
self.assertCountEqual(["og:description"], res.keys()) self.assertCountEqual(["og:description"], res.keys())
def test_ipaddr(self): def test_ipaddr(self):