Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

change monthly_active_users table to be a single column

This commit is contained in:
Neil Johnson 2018-08-01 17:54:37 +01:00
parent d766f26de9
commit ec716a35b2
3 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
synapse/storage/monthly_active_users.py
View File

@ -38,22 +38,18 @@ class MonthlyActiveUsersStore(SQLBaseStore):
return count return count
return self.runInteraction("count_users", _count_users) return self.runInteraction("count_users", _count_users)
def upsert_monthly_active_user(self, user_id): def insert_monthly_active_user(self, user_id):
""" """
Updates or inserts monthly active user member Updates or inserts monthly active user member
Arguments: Arguments:
user_id (str): user to add/update user_id (str): user to add/update
""" """
return self._simple_upsert( return self._simple_insert(
desc="upsert_monthly_active_user", desc="upsert_monthly_active_user",
table="monthly_active_users", table="monthly_active_users",
keyvalues={ values={
"user_id": user_id, "user_id": user_id,
}, },
values={
"timestamp": int(self._clock.time_msec()),
},
lock=False,
) )
@defer.inlineCallbacks @defer.inlineCallbacks

4
synapse/storage/schema/delta/51/monthly_active_users.sql
View File

@ -15,9 +15,7 @@
-- a table of monthly active users, for use where blocking based on mau limits -- a table of monthly active users, for use where blocking based on mau limits
CREATE TABLE monthly_active_users ( CREATE TABLE monthly_active_users (
user_id TEXT NOT NULL, user_id TEXT NOT NULL
timestamp BIGINT NOT NULL
); );
CREATE UNIQUE INDEX monthly_active_users_users ON monthly_active_users(user_id); CREATE UNIQUE INDEX monthly_active_users_users ON monthly_active_users(user_id);
CREATE INDEX monthly_active_users_time_stamp ON monthly_active_users(timestamp);

6
tests/storage/test_monthly_active_users.py
View File

@ -22,7 +22,7 @@ class MonthlyActiveUsersTestCase(tests.unittest.TestCase):
count = yield self.mau.get_monthly_active_count() count = yield self.mau.get_monthly_active_count()
self.assertEqual(0, count) self.assertEqual(0, count)
yield self.mau.upsert_monthly_active_user("@user:server") yield self.mau.insert_monthly_active_user("@user:server")
count = yield self.mau.get_monthly_active_count() count = yield self.mau.get_monthly_active_count()
self.assertEqual(1, count) self.assertEqual(1, count)
@ -34,8 +34,8 @@ class MonthlyActiveUsersTestCase(tests.unittest.TestCase):
user_id3 = "@user3:server" user_id3 = "@user3:server"
result = yield self.mau.is_user_monthly_active(user_id1) result = yield self.mau.is_user_monthly_active(user_id1)
self.assertFalse(result) self.assertFalse(result)
yield self.mau.upsert_monthly_active_user(user_id1) yield self.mau.insert_monthly_active_user(user_id1)
yield self.mau.upsert_monthly_active_user(user_id2) yield self.mau.insert_monthly_active_user(user_id2)
result = yield self.mau.is_user_monthly_active(user_id1) result = yield self.mau.is_user_monthly_active(user_id1)
self.assertTrue(result) self.assertTrue(result)
result = yield self.mau.is_user_monthly_active(user_id3) result = yield self.mau.is_user_monthly_active(user_id3)