Do not call getfullargspec on every call. (#16589)

getfullargspec is relatively expensive and the results will
not change between calls, so precalculate it outside the
wrapper.
This commit is contained in:
Patrick Cloke 2023-10-31 16:16:17 -04:00 committed by GitHub
parent cfb6d38c47
commit ed1b879576
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions

1
changelog.d/16589.misc Normal file
View File

@ -0,0 +1 @@
Improve performance when using opentracing.

View File

@ -1019,11 +1019,14 @@ def tag_args(func: Callable[P, R]) -> Callable[P, R]:
if not opentracing:
return func
# getfullargspec is somewhat expensive, so ensure it is only called a single
# time (the function signature shouldn't change anyway).
argspec = inspect.getfullargspec(func)
@contextlib.contextmanager
def _wrapping_logic(
func: Callable[P, R], *args: P.args, **kwargs: P.kwargs
_func: Callable[P, R], *args: P.args, **kwargs: P.kwargs
) -> Generator[None, None, None]:
argspec = inspect.getfullargspec(func)
# We use `[1:]` to skip the `self` object reference and `start=1` to
# make the index line up with `argspec.args`.
#