Mirrors
/
synapse
mirror of https://github.com/element-hq/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove delay when rotating event push actions (#13211) 

We want to be as up to date as possible, and sleeping doesn't help here
and can mean we fall behind.
This commit is contained in:
Erik Johnston 2022-07-11 16:51:30 +01:00 committed by GitHub
parent 5ef2f87569
commit f1711e1f5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/13211.misc Normal file
View File

@ -0,0 +1 @@
More aggressively rotate push actions.

4
synapse/storage/databases/main/event_push_actions.py
View File

@ -143,7 +143,6 @@ class EventPushActionsWorkerStore(ReceiptsWorkerStore, StreamWorkerStore, SQLBas
self._find_stream_orderings_for_times, 10 * 60 * 1000 self._find_stream_orderings_for_times, 10 * 60 * 1000
) )
self._rotate_delay = 3
self._rotate_count = 10000 self._rotate_count = 10000
self._doing_notif_rotation = False self._doing_notif_rotation = False
if hs.config.worker.run_background_tasks: if hs.config.worker.run_background_tasks:
@ -847,7 +846,6 @@ class EventPushActionsWorkerStore(ReceiptsWorkerStore, StreamWorkerStore, SQLBas
) )
if caught_up: if caught_up:
break break
await self.hs.get_clock().sleep(self._rotate_delay)
# Finally we clear out old event push actions. # Finally we clear out old event push actions.
await self._remove_old_push_actions_that_have_rotated() await self._remove_old_push_actions_that_have_rotated()
@ -1114,7 +1112,7 @@ class EventPushActionsWorkerStore(ReceiptsWorkerStore, StreamWorkerStore, SQLBas
) -> bool: ) -> bool:
# We don't want to clear out too much at a time, so we bound our # We don't want to clear out too much at a time, so we bound our
# deletes. # deletes.
batch_size = 10000 batch_size = self._rotate_count
txn.execute( txn.execute(
""" """