From f842bca471ec19fb0fcf8e71536b113983896140 Mon Sep 17 00:00:00 2001 From: David Baker Date: Thu, 13 Nov 2014 14:34:03 +0000 Subject: [PATCH] Kill ng-animate with fire because it's terrible (was causing the page to be very sluggish). Do the call icons in pure CSS3 and use one less image to boot (in some browsers the phone icon will be the wrong browser but they can deal). --- syweb/webclient/app-controller.js | 8 ++++---- syweb/webclient/app.css | 9 +++++++++ syweb/webclient/app.js | 1 - syweb/webclient/components/matrix/matrix-call.js | 2 +- syweb/webclient/img/red_phone.png | Bin 378 -> 0 bytes syweb/webclient/index.html | 4 +--- 6 files changed, 15 insertions(+), 9 deletions(-) delete mode 100644 syweb/webclient/img/red_phone.png diff --git a/syweb/webclient/app-controller.js b/syweb/webclient/app-controller.js index bbcf4ab5f6..4d89897b1d 100644 --- a/syweb/webclient/app-controller.js +++ b/syweb/webclient/app-controller.js @@ -21,8 +21,8 @@ limitations under the License. 'use strict'; angular.module('MatrixWebClientController', ['matrixService', 'mPresence', 'eventStreamService']) -.controller('MatrixWebClientController', ['$scope', '$location', '$rootScope', '$timeout', '$animate', 'matrixService', 'mPresence', 'eventStreamService', 'eventHandlerService', 'matrixPhoneService', 'modelService', - function($scope, $location, $rootScope, $timeout, $animate, matrixService, mPresence, eventStreamService, eventHandlerService, matrixPhoneService, modelService) { +.controller('MatrixWebClientController', ['$scope', '$location', '$rootScope', '$timeout', 'matrixService', 'mPresence', 'eventStreamService', 'eventHandlerService', 'matrixPhoneService', 'modelService', + function($scope, $location, $rootScope, $timeout, matrixService, mPresence, eventStreamService, eventHandlerService, matrixPhoneService, modelService) { // Check current URL to avoid to display the logout button on the login page $scope.location = $location.path(); @@ -30,8 +30,8 @@ angular.module('MatrixWebClientController', ['matrixService', 'mPresence', 'even // disable nganimate for the local and remote video elements because ngAnimate appears // to be buggy and leaves animation classes on the video elements causing them to show // when they should not (their animations are pure CSS3) - $animate.enabled(false, angular.element('#localVideo')); - $animate.enabled(false, angular.element('#remoteVideo')); + //$animate.enabled(false, angular.element('#localVideo')); + //$animate.enabled(false, angular.element('#remoteVideo')); // Update the location state when the ng location changed $rootScope.$on('$routeChangeSuccess', function (event, current, previous) { diff --git a/syweb/webclient/app.css b/syweb/webclient/app.css index 070e410647..76f3d13ac1 100755 --- a/syweb/webclient/app.css +++ b/syweb/webclient/app.css @@ -66,6 +66,15 @@ textarea, input { margin-left: 4px; margin-right: 4px; margin-top: 8px; + transition: transform linear 0.5s; + transition: -webkit-transform linear 0.5s; +} + +.callIcon.ended { + transform: rotateZ(45deg); + -webkit-transform: rotateZ(45deg); + filter: hue-rotate(-90deg); + -webkit-filter: hue-rotate(-90deg); } #callEndedIcon { diff --git a/syweb/webclient/app.js b/syweb/webclient/app.js index 35190a71f4..1a1be4bd06 100644 --- a/syweb/webclient/app.js +++ b/syweb/webclient/app.js @@ -16,7 +16,6 @@ limitations under the License. var matrixWebClient = angular.module('matrixWebClient', [ 'ngRoute', - 'ngAnimate', 'MatrixWebClientController', 'LoginController', 'RegisterController', diff --git a/syweb/webclient/components/matrix/matrix-call.js b/syweb/webclient/components/matrix/matrix-call.js index a1c3aaa103..56431817d9 100644 --- a/syweb/webclient/components/matrix/matrix-call.js +++ b/syweb/webclient/components/matrix/matrix-call.js @@ -112,7 +112,7 @@ angular.module('MatrixCall', []) } else { var iceServers = []; // https://github.com/EricssonResearch/openwebrtc/issues/85 - if (MatrixCall.turnServer /*&& !this.isOpenWebRTC()*/) { + if (MatrixCall.turnServer && !this.isOpenWebRTC()) { if (MatrixCall.turnServer.uris) { iceServers.push({ 'urls': MatrixCall.turnServer.uris, diff --git a/syweb/webclient/img/red_phone.png b/syweb/webclient/img/red_phone.png deleted file mode 100644 index 11fc44940cb35654bc24874c4cd3c2377dbb353f..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 378 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf2?- z3=n2q{H)3b$dD{?jVKAuPb(=;EJ|f4FE7{2%*!rLPAo{(%P&fw{mw=TsOY<=i(`mI z@6<`Vy__9IT(7r895HGtOG-^mpZ&!1xo_U++9`m1-Tm}*Rr>4aN<~a!*R!X zmJ}_W>E9k`KHkl^X6iJ9lW+DfzI;ijsX)~BfAkIg^9OYzS0Bo~+TW~Z`GfJKc8`$R T(~5b(AYkxx^>bP0l+XkKHXN5X diff --git a/syweb/webclient/index.html b/syweb/webclient/index.html index 4bca320e77..22b6d50ca0 100644 --- a/syweb/webclient/index.html +++ b/syweb/webclient/index.html @@ -16,7 +16,6 @@ - @@ -66,8 +65,7 @@
- - +
{{ currentCall.userProfile.displayname }}