fe8ed1b46f
Make `StreamToken.room_key` be a `RoomStreamToken` instance. ( #8281 )
2020-09-11 12:22:55 +01:00
b86764662b
Fix the exception that is raised when invalid JSON is encountered. ( #8291 )
2020-09-10 14:55:25 -04:00
c312ee3cde
Use TLSv1.2 for fake servers in tests ( #8208 )
...
Some Linux distros have begun disabling TLSv1.0 and TLSv1.1 by default
for security reasons, for example in Fedora 33 onwards:
https://fedoraproject.org/wiki/Changes/StrongCryptoSettings2
Use TLSv1.2 for the fake TLS servers created in the test suite, to avoid
failures due to OpenSSL disallowing TLSv1.0:
<twisted.python.failure.Failure OpenSSL.SSL.Error: [('SSL routines',
'ssl_choose_client_version', 'unsupported protocol')]>
Signed-off-by: Dan Callaghan <djc@djc.id.au>
2020-09-10 19:49:08 +01:00
95d869c357
Add /_synapse/client to the reverse proxy docs ( #8227 )
...
This PR adds a information about forwarding `/_synapse/client` endpoints through your reverse proxy. The first of these endpoints are introduced in https://github.com/matrix-org/synapse/pull/8004 .
2020-09-10 13:26:34 +01:00
5d3e306d9f
Clean up `Notifier.on_new_room_event` code path ( #8288 )
...
The idea here is that we pass the `max_stream_id` to everything, and only use the stream ID of the particular event to figure out *when* the max stream position has caught up to the event and we can notify people about it.
This is to maintain the distinction between the position of an item in the stream (i.e. event A has stream ID 513) and a token that can be used to partition the stream (i.e. give me all events after stream ID 352). This distinction becomes important when the tokens are more complicated than a single number, which they will be once we start tracking the position of multiple writers in the tokens.
The valid operations here are:
1. Is a position before or after a token
2. Fetching all events between two tokens
3. Merging multiple tokens to get the "max", i.e. `C = max(A, B)` means that for all positions P where P is before A *or* before B, then P is before C.
Future PR will change the token type to a dedicated type.
2020-09-10 13:24:43 +01:00
192e98111d
Remove shared rooms info from upgrade/workers doc as it's still experimental ( #8290 )
2020-09-10 13:08:08 +01:00
a3a90ee031
Show a confirmation page during user password reset ( #8004 )
...
This PR adds a confirmation step to resetting your user password between clicking the link in your email and your password actually being reset.
This is to better align our password reset flow with the industry standard of requiring a confirmation from the user after email validation.
2020-09-10 11:45:12 +01:00
e44e9ee518
Merge branch 'release-v1.20.0' into develop
2020-09-10 10:15:02 +01:00
b312769c0e
Do not error when thumbnailing invalid files ( #8236 )
...
If a file cannot be thumbnailed for some reason (e.g. the file is empty), then
catch the exception and convert it to a reasonable error message for the client.
2020-09-09 12:59:41 -04:00
2ea1c68249
Remove some unused distributor signals ( #8216 )
...
Removes the `user_joined_room` and stops calling it since there are no observers.
Also cleans-up some other unused signals and related code.
2020-09-09 12:22:00 -04:00
536f4a2482
1.20.0rc2
2020-09-09 17:08:33 +01:00
c9dbee50ae
Fixup pusher pool notifications ( #8287 )
...
`pusher_pool.on_new_notifications` expected a min and max stream ID, however that was not what we were passing in. Instead, let's just pass it the current max stream ID and have it track the last stream ID it got passed.
I believe that it mostly worked as we called the function for every event. However, it would break for events that got persisted out of order, i.e, that were persisted but the max stream ID wasn't incremented as not all preceding events had finished persisting, and push for that event would be delayed until another event got pushed to the effected users.
2020-09-09 16:56:08 +01:00
dc9dcdbd59
Revert "Fixup pusher pool notifications"
...
This reverts commit e7fd336a53
2020-09-09 16:19:22 +01:00
e7fd336a53
Fixup pusher pool notifications
2020-09-09 16:17:50 +01:00
453dfe210b
blacklist MSC2753 sytests until it's implemented in synapse ( #8285 )
...
Dendrite's implementing MSC2753 over at https://github.com/matrix-org/dendrite/pull/1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at https://github.com/matrix-org/sytest/pull/944 . But we don't want them to run on synapse until synapse implements it.
2020-09-09 13:25:59 +01:00
a5370072b5
Don't remember `enabled` of deleted push rules and properly return 404 for missing push rules in `.../actions` and `.../enabled` ( #7796 )
...
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2020-09-09 11:39:39 +01:00
e45b834119
Add types to async_helpers ( #8260 )
2020-09-08 16:50:51 -04:00
1553adc831
Fix mypy error on develop ( #8282 )
2020-09-08 17:43:31 +01:00
560f3b8609
Include method in thumbnail media name ( #7124 )
...
This fixes an issue where different methods (crop/scale) overwrite each other.
This first tries the new path. If that fails and we are looking for a
remote thumbnail, it tries the old path. If that still isn't found, it
continues as normal.
This should probably be removed in the future, after some of the newer
thumbnails were generated with the new path on most deployments. Then
the overhead should be minimal if the other thumbnails need to be
regenerated.
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
2020-09-08 17:19:50 +01:00
63c0e9e195
Add types to StreamToken and RoomStreamToken ( #8279 )
...
The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.
2020-09-08 16:48:15 +01:00
094896a69d
Add a config option for validating 'next_link' parameters against a domain whitelist ( #8275 )
...
This is a config option ported over from DINUM's Sydent: https://github.com/matrix-org/sydent/pull/285
They've switched to validating 3PIDs via Synapse rather than Sydent, and would like to retain this functionality.
This original purpose for this change is phishing prevention. This solution could also potentially be replaced by a similar one to https://github.com/matrix-org/synapse/pull/8004 , but across all `*/submit_token` endpoint.
This option may still be useful to enterprise even with that safeguard in place though, if they want to be absolutely sure that their employees don't follow links to other domains.
2020-09-08 16:03:09 +01:00
d4daff9b59
Fix /notifications and pushers misbehaving because of unread counts ( #8280 )
2020-09-08 15:26:06 +01:00
0f545e6b96
Clean up types for PaginationConfig ( #8250 )
...
This removes `SourcePaginationConfig` and `get_pagination_rows`. The reasoning behind this is that these generic classes/functions erased the types of the IDs it used (i.e. instead of passing around `StreamToken` it'd pass in e.g. `token.room_key`, which don't have uniform types).
2020-09-08 15:00:17 +01:00
703e2b8a96
Use the right constructor for log records ( #8278 )
...
Update `log_function` to use the right factory to create log records, to make
sure that they have `request` attributes.
Fixes : #8267 .
2020-09-08 14:52:51 +01:00
deedb91732
Fix `MultiWriterIdGenerator.current_position`. ( #8257 )
...
It did not correctly handle IDs finishing being persisted out of
order, resulting in the `current_position` lagging until new IDs are
persisted.
2020-09-08 14:26:54 +01:00
cca03dbec8
Synapse 1.20.0rc1 (2020-09-08)
...
==============================
Removal warning
---------------
Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken ) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](https://github.com/matrix-org/synapse/issues/6766 ).
Features
--------
- Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666 ). ([\#7785](https://github.com/matrix-org/synapse/issues/7785 ))
- Iteratively encode JSON to avoid blocking the reactor. ([\#8013](https://github.com/matrix-org/synapse/issues/8013 ), [\#8116](https://github.com/matrix-org/synapse/issues/8116 ))
- Add support for shadow-banning users (ignoring any message send requests). ([\#8034](https://github.com/matrix-org/synapse/issues/8034 ), [\#8092](https://github.com/matrix-org/synapse/issues/8092 ), [\#8095](https://github.com/matrix-org/synapse/issues/8095 ), [\#8142](https://github.com/matrix-org/synapse/issues/8142 ), [\#8152](https://github.com/matrix-org/synapse/issues/8152 ), [\#8157](https://github.com/matrix-org/synapse/issues/8157 ), [\#8158](https://github.com/matrix-org/synapse/issues/8158 ), [\#8176](https://github.com/matrix-org/synapse/issues/8176 ))
- Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](https://github.com/matrix-org/synapse/issues/8037 ), [\#8107](https://github.com/matrix-org/synapse/issues/8107 ), [\#8252](https://github.com/matrix-org/synapse/issues/8252 ))
- Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654 ). ([\#8059](https://github.com/matrix-org/synapse/issues/8059 ), [\#8254](https://github.com/matrix-org/synapse/issues/8254 ), [\#8270](https://github.com/matrix-org/synapse/issues/8270 ), [\#8274](https://github.com/matrix-org/synapse/issues/8274 ))
- Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](https://github.com/matrix-org/synapse/issues/8198 ))
Bugfixes
--------
- Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](https://github.com/matrix-org/synapse/issues/7864 ))
- Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](https://github.com/matrix-org/synapse/issues/8081 ))
- Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](https://github.com/matrix-org/synapse/issues/8101 ))
- Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](https://github.com/matrix-org/synapse/issues/8104 ))
- Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](https://github.com/matrix-org/synapse/issues/8106 ))
- Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](https://github.com/matrix-org/synapse/issues/8110 ))
- Return a proper error code when the rooms of an invalid group are requested. ([\#8129](https://github.com/matrix-org/synapse/issues/8129 ))
- Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](https://github.com/matrix-org/synapse/issues/8131 ))
- Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](https://github.com/matrix-org/synapse/issues/8135 ))
- Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](https://github.com/matrix-org/synapse/issues/8139 ))
- Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](https://github.com/matrix-org/synapse/issues/8190 ))
- Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](https://github.com/matrix-org/synapse/issues/8223 ))
- Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](https://github.com/matrix-org/synapse/issues/8226 ))
- Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](https://github.com/matrix-org/synapse/issues/8271 ))
Updates to the Docker image
---------------------------
- Fix builds of the Docker image on non-x86 platforms. ([\#8144](https://github.com/matrix-org/synapse/issues/8144 ))
- Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](https://github.com/matrix-org/synapse/issues/8147 ))
Improved Documentation
----------------------
- Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](https://github.com/matrix-org/synapse/issues/8111 ))
- Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](https://github.com/matrix-org/synapse/issues/8120 ))
- Explain better what GDPR-erased means when deactivating a user. ([\#8189](https://github.com/matrix-org/synapse/issues/8189 ))
Internal Changes
----------------
- Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](https://github.com/matrix-org/synapse/issues/7377 ), [\#8163](https://github.com/matrix-org/synapse/issues/8163 ))
- Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](https://github.com/matrix-org/synapse/issues/7757 ))
- Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](https://github.com/matrix-org/synapse/issues/7991 ))
- Convert various parts of the codebase to async/await. ([\#8071](https://github.com/matrix-org/synapse/issues/8071 ), [\#8072](https://github.com/matrix-org/synapse/issues/8072 ), [\#8074](https://github.com/matrix-org/synapse/issues/8074 ), [\#8075](https://github.com/matrix-org/synapse/issues/8075 ), [\#8076](https://github.com/matrix-org/synapse/issues/8076 ), [\#8087](https://github.com/matrix-org/synapse/issues/8087 ), [\#8100](https://github.com/matrix-org/synapse/issues/8100 ), [\#8119](https://github.com/matrix-org/synapse/issues/8119 ), [\#8121](https://github.com/matrix-org/synapse/issues/8121 ), [\#8133](https://github.com/matrix-org/synapse/issues/8133 ), [\#8156](https://github.com/matrix-org/synapse/issues/8156 ), [\#8162](https://github.com/matrix-org/synapse/issues/8162 ), [\#8166](https://github.com/matrix-org/synapse/issues/8166 ), [\#8168](https://github.com/matrix-org/synapse/issues/8168 ), [\#8173](https://github.com/matrix-org/synapse/issues/8173 ), [\#8191](https://github.com/matrix-org/synapse/issues/8191 ), [\#8192](https://github.com/matrix-org/synapse/issues/8192 ), [\#8193](https://github.com/matrix-org/synapse/issues/8193 ), [\#8194](https://github.com/matrix-org/synapse/issues/8194 ), [\#8195](https://github.com/matrix-org/synapse/issues/8195 ), [\#8197](https://github.com/matrix-org/synapse/issues/8197 ), [\#8199](https://github.com/matrix-org/synapse/issues/8199 ), [\#8200](https://github.com/matrix-org/synapse/issues/8200 ), [\#8201](https://github.com/matrix-org/synapse/issues/8201 ), [\#8202](https://github.com/matrix-org/synapse/issues/8202 ), [\#8207](https://github.com/matrix-org/synapse/issues/8207 ), [\#8213](https://github.com/matrix-org/synapse/issues/8213 ), [\#8214](https://github.com/matrix-org/synapse/issues/8214 ))
- Remove some unused database functions. ([\#8085](https://github.com/matrix-org/synapse/issues/8085 ))
- Add type hints to various parts of the codebase. ([\#8090](https://github.com/matrix-org/synapse/issues/8090 ), [\#8127](https://github.com/matrix-org/synapse/issues/8127 ), [\#8187](https://github.com/matrix-org/synapse/issues/8187 ), [\#8241](https://github.com/matrix-org/synapse/issues/8241 ), [\#8140](https://github.com/matrix-org/synapse/issues/8140 ), [\#8183](https://github.com/matrix-org/synapse/issues/8183 ), [\#8232](https://github.com/matrix-org/synapse/issues/8232 ), [\#8235](https://github.com/matrix-org/synapse/issues/8235 ), [\#8237](https://github.com/matrix-org/synapse/issues/8237 ), [\#8244](https://github.com/matrix-org/synapse/issues/8244 ))
- Return the previous stream token if a non-member event is a duplicate. ([\#8093](https://github.com/matrix-org/synapse/issues/8093 ), [\#8112](https://github.com/matrix-org/synapse/issues/8112 ))
- Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](https://github.com/matrix-org/synapse/issues/8113 ))
- Remove `ChainedIdGenerator`. ([\#8123](https://github.com/matrix-org/synapse/issues/8123 ))
- Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](https://github.com/matrix-org/synapse/issues/8124 ))
- Update the test federation client to handle streaming responses. ([\#8130](https://github.com/matrix-org/synapse/issues/8130 ))
- Micro-optimisations to `get_auth_chain_ids`. ([\#8132](https://github.com/matrix-org/synapse/issues/8132 ))
- Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](https://github.com/matrix-org/synapse/issues/8161 ))
- Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](https://github.com/matrix-org/synapse/issues/8164 ), [\#8179](https://github.com/matrix-org/synapse/issues/8179 ))
- Fix tests that were broken due to the merge of 1.19.1. ([\#8167](https://github.com/matrix-org/synapse/issues/8167 ))
- Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](https://github.com/matrix-org/synapse/issues/8171 ))
- Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](https://github.com/matrix-org/synapse/issues/8174 ), [\#8181](https://github.com/matrix-org/synapse/issues/8181 ))
- Standardize the mypy configuration. ([\#8175](https://github.com/matrix-org/synapse/issues/8175 ))
- Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](https://github.com/matrix-org/synapse/issues/8182 ))
- Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](https://github.com/matrix-org/synapse/issues/8196 ))
- Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](https://github.com/matrix-org/synapse/issues/8203 ))
- Refactor queries for device keys and cross-signatures. ([\#8204](https://github.com/matrix-org/synapse/issues/8204 ), [\#8205](https://github.com/matrix-org/synapse/issues/8205 ), [\#8222](https://github.com/matrix-org/synapse/issues/8222 ), [\#8224](https://github.com/matrix-org/synapse/issues/8224 ), [\#8225](https://github.com/matrix-org/synapse/issues/8225 ), [\#8231](https://github.com/matrix-org/synapse/issues/8231 ), [\#8233](https://github.com/matrix-org/synapse/issues/8233 ), [\#8234](https://github.com/matrix-org/synapse/issues/8234 ))
- Fix type hints for functions decorated with `@cached`. ([\#8240](https://github.com/matrix-org/synapse/issues/8240 ))
- Remove obsolete `order` field from federation send queues. ([\#8245](https://github.com/matrix-org/synapse/issues/8245 ))
- Stop sub-classing from object. ([\#8249](https://github.com/matrix-org/synapse/issues/8249 ))
- Add more logging to debug slow startup. ([\#8264](https://github.com/matrix-org/synapse/issues/8264 ))
- Do not attempt to upgrade database schema on worker processes. ([\#8266](https://github.com/matrix-org/synapse/issues/8266 ), [\#8276](https://github.com/matrix-org/synapse/issues/8276 ))
-----BEGIN PGP SIGNATURE-----
iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl9XgG0ACgkQOSor00I9
eP9k9gf8DqxUoYYGGvKrUC0NW5XLLE6qiLI+a+3QqsnWvvAjCzJOPH5xsFWl0YkR
phUmz0KyuIvYokr6RYEG37l7U0hWQKck1/LrgBDOtEWTO+n/bacxNawhJyFOXATc
AZgnCVyhklALUre43QzwlFL1cGQnIBuAHuHa+etj5AO+9eC/QPuJBMryzUVH8dGY
37B2lLTv4ULpSsQ+neQULSyu1EOEyurxNY/RydYaC8bgrOCQgkWPbssQX6MSdHWz
ua+GZ36KAQT6jUmjuTqJXbRKtewjN2anmTb5LrHz1W5GATOY7hH3xsnwHd1oikwW
56vhm1tJZExkWvqfB9XteJcIEZ0epQ==
=JecA
-----END PGP SIGNATURE-----
Merge tag 'v1.20.0rc1' into develop
Synapse 1.20.0rc1 (2020-09-08)
==============================
Removal warning
---------------
Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken ) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](https://github.com/matrix-org/synapse/issues/6766 ).
Features
--------
- Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666 ). ([\#7785](https://github.com/matrix-org/synapse/issues/7785 ))
- Iteratively encode JSON to avoid blocking the reactor. ([\#8013](https://github.com/matrix-org/synapse/issues/8013 ), [\#8116](https://github.com/matrix-org/synapse/issues/8116 ))
- Add support for shadow-banning users (ignoring any message send requests). ([\#8034](https://github.com/matrix-org/synapse/issues/8034 ), [\#8092](https://github.com/matrix-org/synapse/issues/8092 ), [\#8095](https://github.com/matrix-org/synapse/issues/8095 ), [\#8142](https://github.com/matrix-org/synapse/issues/8142 ), [\#8152](https://github.com/matrix-org/synapse/issues/8152 ), [\#8157](https://github.com/matrix-org/synapse/issues/8157 ), [\#8158](https://github.com/matrix-org/synapse/issues/8158 ), [\#8176](https://github.com/matrix-org/synapse/issues/8176 ))
- Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](https://github.com/matrix-org/synapse/issues/8037 ), [\#8107](https://github.com/matrix-org/synapse/issues/8107 ), [\#8252](https://github.com/matrix-org/synapse/issues/8252 ))
- Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654 ). ([\#8059](https://github.com/matrix-org/synapse/issues/8059 ), [\#8254](https://github.com/matrix-org/synapse/issues/8254 ), [\#8270](https://github.com/matrix-org/synapse/issues/8270 ), [\#8274](https://github.com/matrix-org/synapse/issues/8274 ))
- Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](https://github.com/matrix-org/synapse/issues/8198 ))
Bugfixes
--------
- Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](https://github.com/matrix-org/synapse/issues/7864 ))
- Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](https://github.com/matrix-org/synapse/issues/8081 ))
- Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](https://github.com/matrix-org/synapse/issues/8101 ))
- Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](https://github.com/matrix-org/synapse/issues/8104 ))
- Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](https://github.com/matrix-org/synapse/issues/8106 ))
- Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](https://github.com/matrix-org/synapse/issues/8110 ))
- Return a proper error code when the rooms of an invalid group are requested. ([\#8129](https://github.com/matrix-org/synapse/issues/8129 ))
- Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](https://github.com/matrix-org/synapse/issues/8131 ))
- Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](https://github.com/matrix-org/synapse/issues/8135 ))
- Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](https://github.com/matrix-org/synapse/issues/8139 ))
- Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](https://github.com/matrix-org/synapse/issues/8190 ))
- Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](https://github.com/matrix-org/synapse/issues/8223 ))
- Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](https://github.com/matrix-org/synapse/issues/8226 ))
- Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](https://github.com/matrix-org/synapse/issues/8271 ))
Updates to the Docker image
---------------------------
- Fix builds of the Docker image on non-x86 platforms. ([\#8144](https://github.com/matrix-org/synapse/issues/8144 ))
- Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](https://github.com/matrix-org/synapse/issues/8147 ))
Improved Documentation
----------------------
- Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](https://github.com/matrix-org/synapse/issues/8111 ))
- Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](https://github.com/matrix-org/synapse/issues/8120 ))
- Explain better what GDPR-erased means when deactivating a user. ([\#8189](https://github.com/matrix-org/synapse/issues/8189 ))
Internal Changes
----------------
- Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](https://github.com/matrix-org/synapse/issues/7377 ), [\#8163](https://github.com/matrix-org/synapse/issues/8163 ))
- Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](https://github.com/matrix-org/synapse/issues/7757 ))
- Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](https://github.com/matrix-org/synapse/issues/7991 ))
- Convert various parts of the codebase to async/await. ([\#8071](https://github.com/matrix-org/synapse/issues/8071 ), [\#8072](https://github.com/matrix-org/synapse/issues/8072 ), [\#8074](https://github.com/matrix-org/synapse/issues/8074 ), [\#8075](https://github.com/matrix-org/synapse/issues/8075 ), [\#8076](https://github.com/matrix-org/synapse/issues/8076 ), [\#8087](https://github.com/matrix-org/synapse/issues/8087 ), [\#8100](https://github.com/matrix-org/synapse/issues/8100 ), [\#8119](https://github.com/matrix-org/synapse/issues/8119 ), [\#8121](https://github.com/matrix-org/synapse/issues/8121 ), [\#8133](https://github.com/matrix-org/synapse/issues/8133 ), [\#8156](https://github.com/matrix-org/synapse/issues/8156 ), [\#8162](https://github.com/matrix-org/synapse/issues/8162 ), [\#8166](https://github.com/matrix-org/synapse/issues/8166 ), [\#8168](https://github.com/matrix-org/synapse/issues/8168 ), [\#8173](https://github.com/matrix-org/synapse/issues/8173 ), [\#8191](https://github.com/matrix-org/synapse/issues/8191 ), [\#8192](https://github.com/matrix-org/synapse/issues/8192 ), [\#8193](https://github.com/matrix-org/synapse/issues/8193 ), [\#8194](https://github.com/matrix-org/synapse/issues/8194 ), [\#8195](https://github.com/matrix-org/synapse/issues/8195 ), [\#8197](https://github.com/matrix-org/synapse/issues/8197 ), [\#8199](https://github.com/matrix-org/synapse/issues/8199 ), [\#8200](https://github.com/matrix-org/synapse/issues/8200 ), [\#8201](https://github.com/matrix-org/synapse/issues/8201 ), [\#8202](https://github.com/matrix-org/synapse/issues/8202 ), [\#8207](https://github.com/matrix-org/synapse/issues/8207 ), [\#8213](https://github.com/matrix-org/synapse/issues/8213 ), [\#8214](https://github.com/matrix-org/synapse/issues/8214 ))
- Remove some unused database functions. ([\#8085](https://github.com/matrix-org/synapse/issues/8085 ))
- Add type hints to various parts of the codebase. ([\#8090](https://github.com/matrix-org/synapse/issues/8090 ), [\#8127](https://github.com/matrix-org/synapse/issues/8127 ), [\#8187](https://github.com/matrix-org/synapse/issues/8187 ), [\#8241](https://github.com/matrix-org/synapse/issues/8241 ), [\#8140](https://github.com/matrix-org/synapse/issues/8140 ), [\#8183](https://github.com/matrix-org/synapse/issues/8183 ), [\#8232](https://github.com/matrix-org/synapse/issues/8232 ), [\#8235](https://github.com/matrix-org/synapse/issues/8235 ), [\#8237](https://github.com/matrix-org/synapse/issues/8237 ), [\#8244](https://github.com/matrix-org/synapse/issues/8244 ))
- Return the previous stream token if a non-member event is a duplicate. ([\#8093](https://github.com/matrix-org/synapse/issues/8093 ), [\#8112](https://github.com/matrix-org/synapse/issues/8112 ))
- Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](https://github.com/matrix-org/synapse/issues/8113 ))
- Remove `ChainedIdGenerator`. ([\#8123](https://github.com/matrix-org/synapse/issues/8123 ))
- Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](https://github.com/matrix-org/synapse/issues/8124 ))
- Update the test federation client to handle streaming responses. ([\#8130](https://github.com/matrix-org/synapse/issues/8130 ))
- Micro-optimisations to `get_auth_chain_ids`. ([\#8132](https://github.com/matrix-org/synapse/issues/8132 ))
- Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](https://github.com/matrix-org/synapse/issues/8161 ))
- Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](https://github.com/matrix-org/synapse/issues/8164 ), [\#8179](https://github.com/matrix-org/synapse/issues/8179 ))
- Fix tests that were broken due to the merge of 1.19.1. ([\#8167](https://github.com/matrix-org/synapse/issues/8167 ))
- Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](https://github.com/matrix-org/synapse/issues/8171 ))
- Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](https://github.com/matrix-org/synapse/issues/8174 ), [\#8181](https://github.com/matrix-org/synapse/issues/8181 ))
- Standardize the mypy configuration. ([\#8175](https://github.com/matrix-org/synapse/issues/8175 ))
- Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](https://github.com/matrix-org/synapse/issues/8182 ))
- Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](https://github.com/matrix-org/synapse/issues/8196 ))
- Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](https://github.com/matrix-org/synapse/issues/8203 ))
- Refactor queries for device keys and cross-signatures. ([\#8204](https://github.com/matrix-org/synapse/issues/8204 ), [\#8205](https://github.com/matrix-org/synapse/issues/8205 ), [\#8222](https://github.com/matrix-org/synapse/issues/8222 ), [\#8224](https://github.com/matrix-org/synapse/issues/8224 ), [\#8225](https://github.com/matrix-org/synapse/issues/8225 ), [\#8231](https://github.com/matrix-org/synapse/issues/8231 ), [\#8233](https://github.com/matrix-org/synapse/issues/8233 ), [\#8234](https://github.com/matrix-org/synapse/issues/8234 ))
- Fix type hints for functions decorated with `@cached`. ([\#8240](https://github.com/matrix-org/synapse/issues/8240 ))
- Remove obsolete `order` field from federation send queues. ([\#8245](https://github.com/matrix-org/synapse/issues/8245 ))
- Stop sub-classing from object. ([\#8249](https://github.com/matrix-org/synapse/issues/8249 ))
- Add more logging to debug slow startup. ([\#8264](https://github.com/matrix-org/synapse/issues/8264 ))
- Do not attempt to upgrade database schema on worker processes. ([\#8266](https://github.com/matrix-org/synapse/issues/8266 ), [\#8276](https://github.com/matrix-org/synapse/issues/8276 ))
2020-09-08 14:04:20 +01:00
6d01eb0c74
fix typo
2020-09-08 13:27:07 +01:00
bbe2e6b38b
s/fixes/fix/
2020-09-08 13:05:06 +01:00
525efab612
1.20.0rc1
2020-09-08 12:58:37 +01:00
72bec36d50
Directly import json from the standard library. ( #8259 )
...
By importing from canonicaljson the simplejson module was still being used
in some situations. After this change the std lib json is consistenty used
throughout Synapse.
2020-09-08 07:33:48 -04:00
cef00211c8
Allow for make_awaitable's return value to be re-used. ( #8261 )
2020-09-08 07:26:55 -04:00
68cdb3708e
Rename 'populate_stats_process_rooms_2' background job back to 'populate_stats_process_rooms' again ( #8243 )
...
Fixes https://github.com/matrix-org/synapse/issues/8238
Alongside the delta file, some changes were also necessary to the codebase to remove references to the now defunct `populate_stats_process_rooms_2` background job. Thankfully the latter doesn't seem to have made it into any documentation yet :)
2020-09-08 11:05:59 +01:00
ad28030c12
Systemd docs: configure workers to start after main process. ( #8276 )
2020-09-08 10:57:43 +01:00
8d6f97f932
Merge remote-tracking branch 'origin/release-v1.20.0' into develop
2020-09-08 09:58:07 +01:00
d8762cc116
Only add rows to the push actions table if the event notifies or should be marked unread ( #8274 )
2020-09-07 16:56:27 +01:00
77794ebc77
Fix stack overflow when logging system encounters an error ( #8268 )
2020-09-07 16:54:30 +01:00
ef2804d27c
Avoid table-scanning users at startup ( #8271 )
...
This takes about 10 seconds in the best case; often more.
2020-09-07 16:48:52 +01:00
a55e2707d7
Fix unread count failing on NULL values ( #8270 )
...
Fix unread counts making sync fail if the value of the `unread_count`
column in `event_push_summary` is `None`.
2020-09-07 15:15:06 +01:00
0dae7d80bf
Add more logging to debug slow startup ( #8264 )
...
I'm hoping this will provide some pointers for debugging
https://github.com/matrix-org/synapse/issues/7968 .
2020-09-07 13:36:02 +01:00
96312536f2
Refuse to upgrade database on worker processes ( #8266 )
2020-09-07 13:04:10 +01:00
7586fdf1e8
Bump canonicaljson to version 1.4.0 ( #8262 )
...
The version 1.3.0 has a bug with unicode charecters:
```
>>> from canonicaljson import encode_pretty_printed_json
>>> encode_pretty_printed_json({'a': 'à'})
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/erdnaxeli/.pyenv/versions/3.6.7/lib/python3.6/site-packages/canonicaljson.py", line 96, in encode_pretty_printed_json
return _pretty_encoder.encode(json_object).encode("ascii")
UnicodeEncodeError: 'ascii' codec can't encode character '\xe0' in position 12: ordinal not in range(128)
```
Signed-off-by: Alexandre Morignot <erdnaxeli@cervoi.se>
Co-authored-by: Alexandre Morignot <erdnaxeli@cervoi.se>
2020-09-07 12:21:38 +01:00
5b452df23b
Run database updates in a transaction ( #8265 )
...
Fixes : #6467
2020-09-07 11:41:50 +01:00
765437df54
Add tests for `last_successful_stream_ordering` ( #8258 )
2020-09-07 10:11:38 +01:00
77b4711bc2
Merge branch 'release-v1.20.0' into develop
2020-09-06 23:32:28 +01:00
7513006b09
In light of #8255 , use BIGINTs for destination_rooms ( #8256 )
2020-09-04 15:07:29 +01:00
17fa4c7ca7
Catch up after Federation Outage (split, 2): Track last successful stream ordering after transmission ( #8247 )
...
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2020-09-04 15:06:51 +01:00
f25af1f9c7
Add cross-signing sigs to the `keys` object ( #8234 )
...
All the callers want this info in the same place, so let's reduce the
duplication by doing it here.
2020-09-04 15:06:05 +01:00
041ee971c9
Unread counts fixes ( #8254 )
...
* Fixup `ALTER TABLE` database queries
Make the new columns nullable, because doing otherwise can wedge a
server with a big database, as setting a default value rewrites the
table.
* Switch back to using the notifications count in the push badge
Clients are likely to be confused if we send a push but the badge count
is the unread messages one, and not the notifications one.
* Changelog
2020-09-04 14:14:22 +01:00
db7de4d182
Fix a regression from calling read_templates. ( #8252 )
...
Regressed in #8037 .
2020-09-04 09:10:33 -04:00
58f61f10f7
Catch-up after Federation Outage (split, 1) ( #8230 )
...
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
2020-09-04 12:22:23 +01:00
Erik Johnston