Mirrors
/
uBlock
mirror of https://github.com/gorhill/uBlock.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mind isTrusted for click events (see https://palant.de/2017/11/11/on-web-extensions-shortcomings-and-their-impact-on-add-on-security)

This commit is contained in:
gorhill 2017-11-12 07:44:28 -05:00
parent 48f65f11d1
commit 034e46b055
No known key found for this signature in database
GPG Key ID: 25E1490B761470C2
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/js/scriptlets/element-picker.js
View File

@ -1092,6 +1092,7 @@ var filterChoiceFromEvent = function(ev) {
/******************************************************************************/
var onDialogClicked = function(ev) {
if ( ev.isTrusted === false ) { return; }
// If the dialog is hidden, clicking on it force it to become visible.
if ( dialog.classList.contains('hide') ) {
@ -1310,7 +1311,8 @@ var onSvgTouchStartStop = (function() {
type: 'touch',
target: ev.target,
clientX: ev.changedTouches[0].pageX,
clientY: ev.changedTouches[0].pageY
clientY: ev.changedTouches[0].pageY,
isTrusted: ev.isTrusted
});
ev.preventDefault();
return;
@ -1346,6 +1348,8 @@ var onSvgTouchStartStop = (function() {
/******************************************************************************/
var onSvgClicked = function(ev) {
if ( ev.isTrusted === false ) { return; }
// If zap mode, highlight element under mouse, this makes the zapper usable
// on touch screens.
if ( pickerBody.classList.contains('zap') ) {