Mirrors
/
uBlock
mirror of https://github.com/gorhill/uBlock.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

this fixes https://github.com/chrisaljoudi/uBlock/issues/1528 

An XML document can be a valid HTML document. Try to instanciate
a HTMLDivElement to find out whether we are dealing with an actual
HTML document or not.
This commit is contained in:
gorhill 2015-08-28 10:33:58 -04:00
parent 3dd19b7708
commit 1a380f0959
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/js/contentscript-end.js
View File

@ -33,9 +33,14 @@
// https://github.com/chrisaljoudi/uBlock/issues/464 // https://github.com/chrisaljoudi/uBlock/issues/464
if ( document instanceof HTMLDocument === false ) { if ( document instanceof HTMLDocument === false ) {
//console.debug('contentscript-end.js > not a HTLMDocument'); // https://github.com/chrisaljoudi/uBlock/issues/1528
if (
document instanceof XMLDocument === false ||
document.createElement('div') instanceof HTMLDivElement === false
) {
return; return;
} }
}
// I've seen this happens on Firefox // I've seen this happens on Firefox
if ( window.location === null ) { if ( window.location === null ) {

7
src/js/contentscript-start.js
View File

@ -36,9 +36,14 @@
// https://github.com/chrisaljoudi/uBlock/issues/464 // https://github.com/chrisaljoudi/uBlock/issues/464
if ( document instanceof HTMLDocument === false ) { if ( document instanceof HTMLDocument === false ) {
//console.debug('contentscript-start.js > not a HTLMDocument'); // https://github.com/chrisaljoudi/uBlock/issues/1528
if (
document instanceof XMLDocument === false ||
document.createElement('div') instanceof HTMLDivElement === false
) {
return; return;
} }
}
// This can happen // This can happen
if ( typeof vAPI !== 'object' ) { if ( typeof vAPI !== 'object' ) {