From 1f8a67f40eb7293dcb8f4eba9a21cc122dc0d0eb Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Sun, 9 May 2021 11:41:23 -0400 Subject: [PATCH] Fix improper hashing of rules in classic popup panel Related feedback: - https://www.reddit.com/r/uBlockOrigin/comments/n5vaih/ --- src/js/popup.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/js/popup.js b/src/js/popup.js index b2cdc91a5..205c4e527 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -154,13 +154,8 @@ const hashFromPopupData = function(reset) { const rules = popupData.firewallRules; for ( const key in rules ) { const rule = rules[key]; - if ( rule === null ) { continue; } - hasher.push( - rule.src + ' ' + - rule.des + ' ' + - rule.type + ' ' + - rule.action - ); + if ( rule === undefined ) { continue; } + hasher.push(rule); } hasher.sort(); hasher.push(uDom('body').hasClass('off'));