code review re. #134

This commit is contained in:
gorhill 2015-04-26 20:33:49 -04:00
parent af5aeeda6c
commit 28fbda6607
2 changed files with 3 additions and 11 deletions

View File

@ -910,10 +910,9 @@ FilterHostnameDict.prototype.freeze = function() {
var bucket;
for ( var key in buckets ) {
bucket = buckets[key];
if ( typeof bucket !== 'object' ) {
continue;
if ( typeof bucket === 'object' ) {
buckets[key] = this.freezeBucket(bucket);
}
buckets[key] = this.freezeBucket(bucket);
}
};

View File

@ -159,7 +159,7 @@
var µb = this;
var onCompiledListLoaded = function() {
var onSaved = function() {
var compiledFilters = µb.compileFilters(filters);
var snfe = µb.staticNetFilteringEngine;
var cfe = µb.cosmeticFilteringEngine;
@ -176,13 +176,6 @@
µb.cosmeticFilteringEngine.freeze();
};
var onSaved = function(details) {
if ( details.error ) {
return;
}
µb.getCompiledFilterList(µb.userFiltersPath, onCompiledListLoaded);
};
var onLoaded = function(details) {
if ( details.error ) {
return;