Mirrors
/
uBlock
mirror of https://github.com/gorhill/uBlock.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

minor code review

This commit is contained in:
gorhill 2015-12-07 11:06:06 -05:00
parent fd1ccebf41
commit 3b61f7d11d
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/js/scriptlets/cosmetic-logger.js
View File

@ -64,10 +64,6 @@ if ( injectedSelectors.length === 0 ) {
return; return;
} }
// https://github.com/gorhill/uBlock/issues/1015
// Remove runtime prefix used to augment the specificity of our CSS rules.
var reSpecificityBooster = /^:root\s+/;
var matchedSelectors = []; var matchedSelectors = [];
var selector; var selector;
@ -81,7 +77,9 @@ while ( i-- ) {
continue; continue;
} }
loggedSelectors[selector] = true; loggedSelectors[selector] = true;
matchedSelectors.push(selector.replace(reSpecificityBooster, '')); // https://github.com/gorhill/uBlock/issues/1015
// Discard `:root ` prefix.
matchedSelectors.push(selector.slice(6));
} }
vAPI.loggedSelectors = loggedSelectors; vAPI.loggedSelectors = loggedSelectors;

7
src/js/scriptlets/dom-inspector.js
View File

@ -693,9 +693,6 @@ var cosmeticFilterFromTarget = function(nid, coarseSelector) {
/******************************************************************************/ /******************************************************************************/
var cosmeticFilterMapper = (function() { var cosmeticFilterMapper = (function() {
// https://github.com/gorhill/uBlock/issues/1015
var reSpecificityBooster = /^:root\s+/;
// https://github.com/gorhill/uBlock/issues/546 // https://github.com/gorhill/uBlock/issues/546
var matchesFnName; var matchesFnName;
if ( typeof document.body.matches === 'function' ) { if ( typeof document.body.matches === 'function' ) {
@ -717,7 +714,9 @@ var cosmeticFilterMapper = (function() {
var i = selectors.length; var i = selectors.length;
var selector, nodes, j, node; var selector, nodes, j, node;
while ( i-- ) { while ( i-- ) {
selector = selectors[i].replace(reSpecificityBooster, ''); // https://github.com/gorhill/uBlock/issues/1015
// Discard `:root ` prefix.
selector = selectors[i].slice(6);
if ( filterMap.has(rootNode) === false && rootNode[matchesFnName](selector) ) { if ( filterMap.has(rootNode) === false && rootNode[matchesFnName](selector) ) {
filterMap.set(rootNode, selector); filterMap.set(rootNode, selector);
hideNode(node); hideNode(node);