code review for last commit

This commit is contained in:
gorhill 2015-08-15 16:19:38 -04:00
parent 2d131e8fab
commit 56451cf069
1 changed files with 14 additions and 26 deletions

View File

@ -156,55 +156,43 @@ vAPI.browserSettings = {
getValue: function(path, setting) {
var branch = Services.prefs.getBranch(path + '.');
var getMethod;
// https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIPrefBranch#getPrefType%28%29
var getMethod;
switch ( branch.getPrefType(setting) ) {
// PREF_INT
case 64:
case 64: // PREF_INT
getMethod = 'getIntPref';
break;
// PREF_BOOL
case 128:
case 128: // PREF_BOOL
getMethod = 'getBoolPref';
break;
default:
break;
default: // not supported
return;
}
if ( getMethod !== undefined ) {
try {
return branch[getMethod](setting);
} catch (ex) {
}
}
return undefined;
},
setValue: function(path, setting, value) {
var branch = Services.prefs.getBranch(path + '.');
var setMethod;
switch ( typeof value ) {
// PREF_INT
case 'number':
setMethod = 'setIntPref';
break;
// PREF_BOOL
case 'boolean':
setMethod = 'setBoolPref';
break;
default:
break;
default: // not supported
return;
}
if ( setMethod !== undefined ) {
try {
branch[setMethod](setting, value);
Services.prefs.getBranch(path + '.')[setMethod](setting, value);
} catch (ex) {
}
}
},
set: function(details) {