Mirrors
/
uBlock
mirror of https://github.com/gorhill/uBlock.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

code review re. #1884, as per feedback at https://bugs.chromium.org/p/chromium/issues/detail?id=637577#c15

This commit is contained in:
gorhill 2016-10-17 09:37:59 -04:00
parent 2e953b45c9
commit 70ab1a26de
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/js/traffic.js
View File

@ -293,16 +293,17 @@ var onBeforeBehindTheSceneRequest = function(details) {
context.requestHostname = µb.URI.hostnameFromURI(requestURL);
context.requestType = requestType;
// "g" in "gb:" stands for "global setting"
if ( requestType === 'beacon' && µb.userSettings.hyperlinkAuditingDisabled ) {
result = 'gb:no-hyperlink-auditing';
}
// https://bugs.chromium.org/p/chromium/issues/detail?id=637577#c15
// Do not filter behind-the-scene network request of type `beacon`: there
// is no point. In any case, this will become a non-issue once
// <https://bugs.chromium.org/p/chromium/issues/detail?id=522129> is
// fixed.
// Blocking behind-the-scene requests can break a lot of stuff: prevent
// browser updates, prevent extension updates, prevent extensions from
// working properly, etc.
// So we filter if and only if the "advanced user" mode is selected
if ( result === '' && µb.userSettings.advancedUserEnabled ) {
if ( µb.userSettings.advancedUserEnabled ) {
result = pageStore.filterRequestNoCache(context);
}