Mirrors
/
uBlock
mirror of https://github.com/gorhill/uBlock.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

code review

This commit is contained in:
gorhill 2015-01-10 11:32:24 -05:00
parent 9fc136e7e8
commit 80ef8f3777
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/js/popup.js
View File

@ -299,7 +299,6 @@ var renderPopup = function() {
// Condition for dynamic filtering toggler: // Condition for dynamic filtering toggler:
// - Advanced user // - Advanced user
uDom('body').removeClass('dirty');
uDom('body').toggleClass('advancedUser', popupData.advancedUserEnabled); uDom('body').toggleClass('advancedUser', popupData.advancedUserEnabled);
uDom('#switch').toggleClass('off', popupData.pageURL === '' || !popupData.netFilteringSwitch); uDom('#switch').toggleClass('off', popupData.pageURL === '' || !popupData.netFilteringSwitch);
@ -544,15 +543,15 @@ var reloadTab = function() {
// //
// - broadcasting() is not an option given there could be a lot of tabs opened, // - broadcasting() is not an option given there could be a lot of tabs opened,
// and maybe even many frames within these tabs, i.e. unacceptable overhead // and maybe even many frames within these tabs, i.e. unacceptable overhead
// regardless of whether the popup is opened or not). // regardless of whether the popup is opened or not.
// //
// - Modifying the messaging API is not an option, as this would require // - Modifying the messaging API is not an option, as this would require
// revisiting all platform-specific code to support targeted broadcasting, // revisiting all platform-specific code to support targeted broadcasting,
// which who knows could be not so trivial for some platforms. // which who knows could be not so trivial for some platforms.
// //
// A well done polling is a better anyways IMO, I prefer that data is pulled // A well done polling is a better anyways IMO, I prefer that data is pulled
// on demand rather than having the main process assumes somebody may need to // on demand rather than forcing the main process to assume a client may need
// be expressly notified. // it and thus having to push it all the time unconditionally.
var pollForContentChange = (function() { var pollForContentChange = (function() {
var pollTimer = null; var pollTimer = null;