From 9884ff115a5c1f0727486a929b608cd7f60f76a2 Mon Sep 17 00:00:00 2001 From: gorhill Date: Tue, 7 Nov 2017 17:03:24 -0500 Subject: [PATCH] code review e7294a46d4ff: force refresh tooltip if needed --- src/js/popup.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/js/popup.js b/src/js/popup.js index 5f2b0db53..0c0fc8481 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -505,7 +505,7 @@ var renderPopup = function() { // https://github.com/gorhill/uBlock/issues/2889 // Use tooltip for ARIA purpose. -var renderTooltips = function() { +var renderTooltips = function(selector) { var elem = uDom.nodeFromId('switch'), off = document.body.classList.contains('off'), text; @@ -518,6 +518,10 @@ var renderTooltips = function() { elem.setAttribute('aria-label', text); elem.setAttribute('data-tip', text); } + if ( typeof selector === 'string' ) { + uDom.nodeFromId('tooltip').textContent = + uDom.nodeFromSelector(selector).getAttribute('data-tip'); + } }; /******************************************************************************/ @@ -621,7 +625,7 @@ var toggleNetFilteringSwitch = function(ev) { tabId: popupData.tabId } ); - renderTooltips(); + renderTooltips('#switch'); hashFromPopupData(); };