Mirrors
/
uBlock
mirror of https://github.com/gorhill/uBlock.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

code review: use setIcon w/ ImageData only for chromium-based browsers

This commit is contained in:
Raymond Hill 2018-05-09 08:08:19 -04:00
parent 82e5fa61b9
commit a9a1cc3f3b
No known key found for this signature in database
GPG Key ID: 25E1490B761470C2
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
platform/chromium/vapi-background.js
View File

@ -667,12 +667,17 @@ vAPI.setIcon = (function() {
}); });
} }
if ( // As of 2018-05, benchmarks show that only Chromium benefits for sure
vAPI.webextFlavor.soup.has('chromium') === false && // from using ImageData.
vAPI.webextFlavor.soup.has('firefox') === false //
) { // Chromium creates a new ImageData instance every call to setIcon
return; // with paths:
} // https://cs.chromium.org/chromium/src/extensions/renderer/resources/set_icon.js?l=56&rcl=99be185c25738437ecfa0dafba72a26114196631
//
// Firefox uses an internal cache for each setIcon's paths:
// https://searchfox.org/mozilla-central/rev/5ff2d7683078c96e4b11b8a13674daded935aa44/browser/components/extensions/parent/ext-browserAction.js#631
if ( vAPI.webextFlavor.soup.has('chromium') === false ) { return; }
let imgs = [ let imgs = [
{ i: 0, p: '16' }, { i: 0, p: '32' }, { i: 0, p: '16' }, { i: 0, p: '32' },
{ i: 1, p: '16' }, { i: 1, p: '32' }, { i: 1, p: '16' }, { i: 1, p: '32' },