From ad77938f24d10ca9b7e92c1072d6545736dc00a9 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Wed, 29 May 2024 09:57:09 -0400 Subject: [PATCH] [mv3] Raise minimum chromium version to 118 This allows to drop the special handling of `isUrlFilterCaseSensitive` for chromium-based browsers. --- platform/mv3/chromium/manifest.json | 2 +- platform/mv3/make-rulesets.js | 18 ------------------ 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/platform/mv3/chromium/manifest.json b/platform/mv3/chromium/manifest.json index 036dc2d24..b3e77ccc2 100644 --- a/platform/mv3/chromium/manifest.json +++ b/platform/mv3/chromium/manifest.json @@ -25,7 +25,7 @@ "128": "img/icon_128.png" }, "manifest_version": 3, - "minimum_chrome_version": "105.0", + "minimum_chrome_version": "118.0", "name": "__MSG_extName__", "options_page": "dashboard.html", "optional_host_permissions": [ diff --git a/platform/mv3/make-rulesets.js b/platform/mv3/make-rulesets.js index 4f79d52dd..fd842db38 100644 --- a/platform/mv3/make-rulesets.js +++ b/platform/mv3/make-rulesets.js @@ -338,24 +338,6 @@ async function processNetworkFilters(assetDetails, network) { log(`\tRejected filter count: ${network.rejectedFilterCount}`); log(`Output rule count: ${rules.length}`); - // https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/RuleCondition#browser_compatibility - // isUrlFilterCaseSensitive is true by default in Chromium. It will be - // false by default in Chromium 118+. - if ( platform !== 'firefox' ) { - for ( const rule of rules ) { - const { condition } = rule; - if ( condition === undefined ) { continue; } - if ( condition.urlFilter === undefined ) { - if ( condition.regexFilter === undefined ) { continue; } - } - if ( condition.isUrlFilterCaseSensitive === undefined ) { - condition.isUrlFilterCaseSensitive = false; - } else if ( condition.isUrlFilterCaseSensitive === true ) { - condition.isUrlFilterCaseSensitive = undefined; - } - } - } - // Minimize requestDomains arrays for ( const rule of rules ) { const condition = rule.condition;