From b75921c2fd0a704e7c3fc35453aa6223c0c91442 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Tue, 6 Jul 2021 10:13:50 -0400 Subject: [PATCH] Limit recursion when parsing URL in document-blocked page Related issue: - https://github.com/uBlockOrigin/uBlock-issues/issues/1649 --- src/js/document-blocked.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/js/document-blocked.js b/src/js/document-blocked.js index 08b2fd732..b0034ef3a 100644 --- a/src/js/document-blocked.js +++ b/src/js/document-blocked.js @@ -144,7 +144,9 @@ uDom.nodeFromId('why').textContent = details.fs; return s; }; - const renderParams = function(parentNode, rawURL) { + // https://github.com/uBlockOrigin/uBlock-issues/issues/1649 + // Limit recursion. + const renderParams = function(parentNode, rawURL, depth = 0) { const a = document.createElement('a'); a.href = rawURL; if ( a.search.length === 0 ) { return false; } @@ -165,9 +167,9 @@ uDom.nodeFromId('why').textContent = details.fs; const name = safeDecodeURIComponent(param.slice(0, pos)); const value = safeDecodeURIComponent(param.slice(pos + 1)); const li = liFromParam(name, value); - if ( reURL.test(value) ) { + if ( depth < 2 && reURL.test(value) ) { const ul = document.createElement('ul'); - renderParams(ul, value); + renderParams(ul, value, depth + 1); li.appendChild(ul); } parentNode.appendChild(li);