mirror of https://github.com/gorhill/uBlock.git
#1514: code review
This commit is contained in:
parent
aed185ba3f
commit
baed91e111
|
@ -31,23 +31,29 @@
|
||||||
null
|
null
|
||||||
);
|
);
|
||||||
|
|
||||||
|
if ( !this.docShell ) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
let webProgress = this.docShell
|
||||||
|
.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
|
||||||
|
.getInterface(Components.interfaces.nsIWebProgress);
|
||||||
|
if ( !webProgress ) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
// https://github.com/gorhill/uBlock/issues/1514
|
||||||
|
// Fix?
|
||||||
|
let domWindow = webProgress.DOMWindow;
|
||||||
|
if ( domWindow !== domWindow.top ) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
// https://github.com/gorhill/uBlock/issues/1444
|
// https://github.com/gorhill/uBlock/issues/1444
|
||||||
// Apparently, on older versions of Firefox (31 and less), the same context
|
// Apparently, on older versions of Firefox (31 and less), the same context
|
||||||
// is used for all extensions, hence we must use a unique variable name to
|
// is used for all extensions, hence we must use a unique variable name to
|
||||||
// ensure no collision.
|
// ensure no collision.
|
||||||
this.ublock0LocationChangeListener = null;
|
this.ublock0LocationChangeListener = new LocationChangeListener(this.docShell, webProgress);
|
||||||
|
|
||||||
// https://github.com/gorhill/uBlock/issues/1514
|
|
||||||
// Fix?
|
|
||||||
if ( this.docShell ) {
|
|
||||||
let webProgress = this.docShell
|
|
||||||
.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
|
|
||||||
.getInterface(Components.interfaces.nsIWebProgress);
|
|
||||||
let domWindow = webProgress.DOMWindow;
|
|
||||||
if ( domWindow === domWindow.top ) {
|
|
||||||
this.ublock0LocationChangeListener = new LocationChangeListener(this.docShell, webProgress);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}).call(this);
|
}).call(this);
|
||||||
|
|
||||||
/******************************************************************************/
|
/******************************************************************************/
|
||||||
|
|
Loading…
Reference in New Issue