From bf50e87dffc0c2286ef72890b629a0b5b15d0cd8 Mon Sep 17 00:00:00 2001 From: gorhill Date: Mon, 9 Mar 2015 23:00:52 -0400 Subject: [PATCH] this fixes #976 --- src/js/storage.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/js/storage.js b/src/js/storage.js index c75980116..f79122969 100644 --- a/src/js/storage.js +++ b/src/js/storage.js @@ -99,8 +99,8 @@ /******************************************************************************/ -µBlock.appendUserFilters = function(content) { - if ( content.length === 0 ) { +µBlock.appendUserFilters = function(filter) { + if ( filter.length === 0 ) { return; } @@ -130,10 +130,11 @@ if ( details.error ) { return; } - if ( details.content.indexOf(content.trim()) !== -1 ) { - return; - } - µb.saveUserFilters(details.content.trim() + '\n\n' + content.trim(), onSaved); + // https://github.com/gorhill/uBlock/issues/976 + // If we reached this point, the filter quite probably needs to be + // added for sure: do not try to be too smart, trying to avoid + // duplicates at this point may lead to more issues. + µb.saveUserFilters(details.content.trim() + '\n\n' + filter.trim(), onSaved); }; this.loadUserFilters(onLoaded);