code review

This commit is contained in:
gorhill 2015-06-01 09:00:10 -04:00
parent d724fb23bd
commit f458fa4adf
1 changed files with 6 additions and 6 deletions

View File

@ -528,7 +528,7 @@ vAPI.tabs.open = function(details) {
details.url = vAPI.getURL(details.url);
}
var win, tab, tabBrowser;
var tab;
if ( details.select ) {
var URI = Services.io.newURI(details.url, null, null);
@ -558,8 +558,8 @@ vAPI.tabs.open = function(details) {
}
}
win = Services.wm.getMostRecentWindow('navigator:browser');
tabBrowser = getTabBrowser(win);
var win = Services.wm.getMostRecentWindow('navigator:browser');
var tabBrowser = getTabBrowser(win);
if ( vAPI.fennec ) {
tabBrowser.addTab(details.url, {selected: details.active !== false});
@ -590,9 +590,9 @@ vAPI.tabs.replace = function(tabId, url) {
targetURL = vAPI.getURL(targetURL);
}
var tab = tabWatcher.browserFromTabId(tabId);
if ( tab ) {
tabWatcher.browserFromTarget(tab).loadURI(targetURL);
var browser = tabWatcher.browserFromTabId(tabId);
if ( browser ) {
browser.loadURI(targetURL);
}
};