From 5acdd0e2cbae777155ceb40b8835947d38f94c0c Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Fri, 5 Nov 2021 10:22:38 +0000 Subject: [PATCH] bulletproofs+: some minor cleanup from vtnerd's review --- src/ringct/bulletproofs_plus.cc | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/ringct/bulletproofs_plus.cc b/src/ringct/bulletproofs_plus.cc index 5aebba450..3d27849c1 100644 --- a/src/ringct/bulletproofs_plus.cc +++ b/src/ringct/bulletproofs_plus.cc @@ -265,7 +265,7 @@ namespace rct rct::key res = ONE; if (n == 1) - return res; + return x; n += 1; rct::key x1 = copy(x); @@ -317,16 +317,7 @@ namespace rct static rct::key weighted_inner_product(const rct::keyV &a, const epee::span &b, const rct::key &y) { CHECK_AND_ASSERT_THROW_MES(a.size() == b.size(), "Incompatible sizes of a and b"); - rct::key res = rct::zero(); - rct::key y_power = ONE; - rct::key temp; - for (size_t i = 0; i < a.size(); ++i) - { - sc_mul(temp.bytes, a[i].bytes, b[i].bytes); - sc_mul(y_power.bytes, y_power.bytes, y.bytes); - sc_muladd(res.bytes, temp.bytes, y_power.bytes, res.bytes); - } - return res; + return weighted_inner_product(epee::to_span(a), b, y); } // Fold inner-product point vectors