Merge pull request #1615

f0989893 core: cache tx hashes of failing semantics txes (moneromooo-monero)
This commit is contained in:
Riccardo Spagni 2017-01-22 11:51:53 -05:00
commit 9c06a7fd04
No known key found for this signature in database
GPG Key ID: 55432DF31CCD4FCD
2 changed files with 10 additions and 0 deletions

View File

@ -487,6 +487,13 @@ namespace cryptonote
}
//std::cout << "!"<< tx.vin.size() << std::endl;
if (bad_semantics_txes.find(tx_hash) != bad_semantics_txes.end())
{
LOG_PRINT_L1("Transaction already seen with bad semantics, rejected");
tvc.m_verifivation_failed = true;
return false;
}
uint8_t version = m_blockchain_storage.get_current_hard_fork_version();
const size_t max_tx_version = version == 1 ? 1 : 2;
if (tx.version == 0 || tx.version > max_tx_version)
@ -534,6 +541,7 @@ namespace cryptonote
if(!check_tx_semantic(tx, keeped_by_block))
{
LOG_PRINT_L1("WRONG TRANSACTION BLOB, Failed to check tx " << tx_hash << " semantic, rejected");
bad_semantics_txes.insert(tx_hash);
tvc.m_verifivation_failed = true;
return false;
}

View File

@ -824,6 +824,8 @@ namespace cryptonote
size_t block_sync_size;
time_t start_time;
std::unordered_set<crypto::hash> bad_semantics_txes;
};
}