b81e276cab
connection_context: initialize m_last_request_time to current time
...
This prevents spurious early peer drops
2018-02-04 13:13:08 +00:00
928c1825f0
cryptonote_protocol: guard against all threads in standby
2018-02-02 22:33:53 +00:00
2e3e90acbe
pass large parameters by const ref, not value
...
Coverity 136394 136397 136409 136526 136529 136533 175302
2018-02-02 19:36:09 +00:00
61defd89e3
blockchain: sanity check number of precomputed hash of hash blocks
...
Coverity 142951
2018-02-02 17:10:13 +00:00
9af6b2d1b8
ringct: fix infinite loop in unused h2b function
...
Coverity 146775
2018-02-02 16:44:28 +00:00
8cea8d0cef
simplewallet: double check a new multisig wallet is multisig
...
Coverity 182493
2018-02-02 16:41:16 +00:00
9b98a6ac8f
threadpool: catch exceptions in dtor, to avoid terminate
...
If an exception is thrown, it is ignored. While this may hide
a bug, this should only be system exceptions in boost, which
is pretty unlikely. Morever, wait should be called manually
before the dtor anyway. Add an error message if the dtor has
to wait in case some such cases creep in so they get fixed.
Coverity 182538
2018-02-02 16:27:39 +00:00
24803ed91f
blockchain_export: fix buffer overflow in exporter
...
Coverity 182550
2018-02-02 16:11:15 +00:00
f3f7da624d
perf_timer: rewrite to make it clear there is no division by zero
...
It could have happened if epee::misc_utils::get_ns_count
is buggy, at a push
Coverity 182561
2018-02-02 16:06:36 +00:00
c6ea3df0ae
performance_tests: remove add_arg call stray extra param
...
Coverity 182572
2018-02-02 15:59:54 +00:00
fa6b45665d
fuzz_tests: fix an uninitialized var in setup
...
and comment it out, it's only used to generate a starting test case
Coverity 182506
2018-02-02 15:56:44 +00:00
03887f1140
keccak: fix sanity check bounds test
...
Nothing calls this with those inputs
2018-02-02 15:48:06 +00:00
ad11db9144
blockchain_db: initialize m_open in base class ctor
...
It's cleaner this way, since it's a base class field
Coverity 136568
2018-02-02 15:21:39 +00:00
bece67f9e8
miner: restore std::cout precision after modification
...
Coverity 136462
2018-02-02 15:15:21 +00:00
1aabd14c21
db_lmdb: check hard fork info drop succeeded
...
Coverity 136364
2018-02-02 15:08:22 +00:00
49c803ad7d
Dockerfile: build dependencies with -fPIC
2018-02-02 13:45:28 +00:00
3b4e6b35b3
txpool: increase unmined tx expiry to three days
2018-02-01 22:48:52 +00:00
2e584dcb1f
p2p: do not try to connect to peers in offline mode
2018-02-01 20:18:30 +00:00
851bd057ec
call _exit instead of abort in release mode
...
Avoids cores being created, as they're nowadays often piped
to some call home system
2018-02-01 13:32:46 +00:00
399921347f
txpool: Properly bail out when outputs_amount == inputs_amount
...
Previously, when outputs_amount == inputs_amount, the "m_overspend" property
was set, whereas "m_fee_too_low" would have been the correct property to set.
This is unlikely to ever occur and just something I've noticed while reading
through the code.
2018-02-01 00:48:45 +01:00
84a8b2da14
Don't create readtxn until after txn_safe gate check
2018-01-31 18:18:01 +00:00
3f1a3fac00
bulletproofs: more robust challenge computation
...
Changes from sarang, from a recommendation by an anonymous reviewer
2018-01-31 15:57:01 +00:00
b809058993
ringct: pseudoOuts moved to prunable in the simple bulletproof case
...
Saves 64 bytes non prunable data per typical tx
This breaks v7 consensus, will require a testnet reorg from v6
2018-01-31 15:56:26 +00:00
19ff243f52
wallets: reorg 61 more days on testnet
2018-01-31 15:52:43 +00:00
c70f03cacf
blockchain: move bulletproofs to v8
...
and set v7 height to 1057027 on testnet (one block earlier)
This is to easily dump current nodes since we're going to change
the v7 rules with this.
2018-01-31 15:52:39 +00:00
fde4489e1d
wipeable_string: call memwipe directly
...
since the original reason for the indirect call (that memwipe
was not in contrib) is now gone
2018-01-31 12:25:30 +00:00
a99ef17695
wallet-rpc: take subaddress account as arg for get_transfer_by_txid
2018-01-31 17:53:02 +09:00
7712509644
wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDS
2018-01-31 17:52:31 +09:00
7539603f94
Bootstrap daemon
2018-01-30 20:15:47 +09:00
a85dbb3f2f
Fixed typos and wording tweaks
2018-01-29 12:13:23 +01:00
402c9eef0e
cryptonote_tx_utils: fixed logic bug in get_destination_view_key_pub
2018-01-29 17:05:07 +09:00
f90c76beb4
Return appropriate error code when there's no connection to daemon
2018-01-29 08:28:25 +01:00
628b78ae8a
Fix in_peers/out_peers RPC operations
...
Original implementations could never have worked.
2018-01-29 11:54:57 +11:00
ece9bcf5c6
rpc_client: Fix error handling
...
Previous code was unable to distingush between a connection error
and a communication error.
2018-01-29 11:54:57 +11:00
8f30350d03
Fix method name in invoke_http_json_rpc
...
Previously, the method name was printed as an exmpty string because
the input string had already been moved with `std::move`.
2018-01-29 11:14:02 +11:00
32c0f908cd
Allow the number of incoming connections to be limited
...
It was already possible to limit outgoing connections. One might want
to do this on home network connections with high bandwidth but low
usage caps.
2018-01-29 11:14:02 +11:00
d609a2c164
Rename delete_connections to delete_out_connections
...
This rename is needed so that delete_in_connections can be added.
2018-01-29 07:06:08 +11:00
b927c0fc7a
Rename connections_count to max_out_connection_count
...
This is needed so that a max_in_connection_count can be added.
2018-01-29 07:06:08 +11:00
ed67e5c001
Merge pull request #3198
...
1c99a628
2018-01-28 09:59:59 -08:00
4fcf609942
Merge pull request #3186
...
7ed62e63
2018-01-28 09:54:17 -08:00
30ce8c5926
cn_deserialize: check for raw tx_extra
2018-01-28 15:23:05 +00:00
1c99a628e3
Tests: Fix building of two fuzz tests on Windows
2018-01-28 14:51:02 +01:00
3cb65b3f69
Return appropriate error code when not enough money for tx
2018-01-28 12:52:05 +01:00
eda9fb5b98
p2p: fix testnet/mainnet port mixup
2018-01-28 09:44:04 +00:00
9017084a7b
cmake: add -DHAVE_ defines to the command line
...
since there's no config.h here
2018-01-28 08:57:51 +00:00
6ed314854c
Merge pull request #3188
...
fbc0a6dd
2018-01-27 18:21:55 -08:00
00a1166c95
Merge pull request #3185
...
fccd1df1
2018-01-27 18:21:40 -08:00
29fafa4ca7
Merge pull request #3123
...
30c44bcec903df5e2f5a9b6b
2018-01-27 18:08:56 -08:00
30c44bce06
wallet: automatically use low priority if safe (no backlog & recent blocks not full)
2018-01-28 11:04:52 +09:00
c903df5ece
simplewallet: bug fix for backlog estimate
2018-01-28 10:52:25 +09:00
moneromooo-monero